Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phx.gen.auth creates Cycle of length 3 #6030

Open
lifeiscontent opened this issue Dec 25, 2024 · 2 comments
Open

phx.gen.auth creates Cycle of length 3 #6030

lifeiscontent opened this issue Dec 25, 2024 · 2 comments

Comments

@lifeiscontent
Copy link
Contributor

Environment

  • Elixir version (elixir -v):
    Erlang/OTP 27 [erts-15.1.2] [source] [64-bit] [smp:10:10] [ds:10:10:10] [async-threads:1] [jit]

Elixir 1.17.3 (compiled with Erlang/OTP 25)

  • Phoenix version (mix deps): 1.7.18
  • Operating system: MacOS

Actual behavior

after running mix phx.gen.auth

mix xref graph --format cycles --label compile-connected

1 cycles found. Showing them in decreasing size:

Cycle of length 3:

    lib/example_web/router.ex
    lib/example_web/user_auth.ex (compile)
    lib/example_web/endpoint.ex

Expected behavior

no cycles detected

@chx
Copy link

chx commented Feb 3, 2025

I can't reproduce this on Erlang/OTP 26.

Here are the commands I ran

git clone https://github.com/phoenixframework/phoenix
cd phoenix/installer
mix phx.new dev_app --dev --database mysql
cd dev_app
mysql -e 'create database dev_app_dev'
mix ecto.create
mix phx.gen.auth Accounts User users
mix deps.get
mix xref graph --format cycles --label compile-connected

I answered yes to Do you want to create a LiveView based authentication system? [Yn]

This ended with No cycles found.

Erlang/OTP 26 [erts-14.2.5.3] [source] [64-bit] [smp:16:16] [ds:16:16:10] [async-threads:1] [jit:ns]

Elixir 1.17.3 (compiled with Erlang/OTP 26)

@lifeiscontent
Copy link
Contributor Author

@chx I'll try to reproduce this again with more detail if that helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants