Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA Certificate Resolution in mix phx.gen.release --docker doesn't support custom CA Certs #6066

Closed
DnOberon opened this issue Jan 30, 2025 · 3 comments

Comments

@DnOberon
Copy link

DnOberon commented Jan 30, 2025

I will be opening a PR but wanted to open an issue and make sure I can do this at all.\

https://github.com/phoenixframework/phoenix/blob/v1.7.18/lib/mix/tasks/phx.gen.release.ex#L297

Referencing Jose's PR here - erlang/otp#8920 about CA certs, we need to update these http calls to respect users who need to provide custom CA certs like those behind corporate SSL inspection.

I'll be updating this to use the underlying erlang method of loading certificates if that's ok?

@josevalim
Copy link
Member

Yes, please go ahead!

@josevalim
Copy link
Member

Actually, I go ahead and push something myself. :)

josevalim added a commit that referenced this issue Jan 31, 2025
@DnOberon
Copy link
Author

I don't know how you find time for this amidst all that you do. Thanks and you beat me to it :)

SteffenDE pushed a commit that referenced this issue Feb 17, 2025
* Use :public_key.cacerts_get, closes #6066

* Bump OTP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants