Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update router.ex doc #3667

Merged

Conversation

ericridgeway
Copy link
Contributor

@ericridgeway ericridgeway commented Feb 7, 2025

Remove reference to live_path

Use VerifiedRoutes instead of named route helpers, as explained in: https://hexdocs.pm/phoenix/Phoenix.VerifiedRoutes.html#module-what-about-named-routes

Fixes #3666

Remove reference to live_path

Use VerifiedRoutes instead of named route helpers: https://hexdocs.pm/phoenix/Phoenix.VerifiedRoutes.html#module-what-about-named-routes
@ericridgeway ericridgeway changed the title Update router.ex Update router.ex doc Feb 7, 2025
@SteffenDE
Copy link
Collaborator

The live_path is part of the deprecated route helpers that aren't generated by default any more for apps generated with phx.new, see https://hexdocs.pm/phoenix/Phoenix.Router.html#module-helpers-deprecated. We should look at other places in the docs as well where they are mentioned and say that those are deprecated. I'm not sure if we should remove the references to them, since they can still be used (cc @josevalim).

@josevalim
Copy link
Member

We should remove the reference to them.

@josevalim josevalim merged commit 16356a3 into phoenixframework:main Feb 7, 2025
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@ericridgeway ericridgeway deleted the update-live_path-reference branch February 7, 2025 09:35
SteffenDE pushed a commit that referenced this pull request Feb 18, 2025
Use VerifiedRoutes instead of named route helpers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LiveView Router Helpers doc for live_path incomplete / out-of-date
3 participants