Making cache tags more efficient by rewriting the API.

Related to php-cache/issues#21

Author: Nyholm

RedisCachePool.php

@@ -14,14 +14,18 @@
 use Cache\Adapter\Common\AbstractCachePool;
 use Cache\Hierarchy\HierarchicalCachePoolTrait;
 use Cache\Hierarchy\HierarchicalPoolInterface;
+use Cache\Taggable\TaggableItemInterface;
+use Cache\Taggable\TaggablePoolInterface;
+use Cache\Taggable\TaggablePoolTrait;
 use Psr\Cache\CacheItemInterface;
 
 /**
  * @author Tobias Nyholm <[email protected]>
  */
-class RedisCachePool extends AbstractCachePool implements HierarchicalPoolInterface
+class RedisCachePool extends AbstractCachePool implements HierarchicalPoolInterface, TaggablePoolInterface
 {
     use HierarchicalCachePoolTrait;
+    use TaggablePoolTrait;
 
     /**
      * @type \Redis
@@ -39,7 +43,7 @@ public function __construct(\Redis $cache)
     protected function fetchObjectFromCache($key)
     {
         if (false === $result = unserialize($this->cache->get($this->getHierarchyKey($key)))) {
-            return [false, null];
+            return [false, null, []];
         }
 
         return $result;
@@ -53,26 +57,56 @@ protected function clearAllObjectsFromCache()
     protected function clearOneObjectFromCache($key)
     {
         $this->commit();
+        $this->preRemoveItem($key);
         $keyString = $this->getHierarchyKey($key, $path);
         $this->cache->incr($path);
         $this->clearHierarchyKeyCache();
 
         return $this->cache->del($keyString) >= 0;
     }
 
-    protected function storeItemInCache($key, CacheItemInterface $item, $ttl)
+    protected function storeItemInCache(CacheItemInterface $item, $ttl)
     {
-        $key  = $this->getHierarchyKey($key);
-        $data = serialize([true, $item->get()]);
-        if ($ttl === null) {
+        $key  = $this->getHierarchyKey($item->getKey());
+        $data = serialize([true, $item->get(), $item->getTags()]);
+        if ($ttl === null || $ttl === 0) {
             return $this->cache->set($key, $data);
         }
 
         return $this->cache->setex($key, $ttl, $data);
     }
 
+    public function save(CacheItemInterface $item)
+    {
+        if ($item instanceof TaggableItemInterface) {
+            $this->saveTags($item);
+        }
+
+        return parent::save($item);
+    }
+
     protected function getValueFormStore($key)
     {
         return $this->cache->get($key);
     }
+
+    protected function appendListItem($name, $value)
+    {
+        $this->cache->lPush($name, $value);
+    }
+
+    protected function getList($name)
+    {
+        return $this->cache->lRange($name, 0, -1);
+    }
+
+    protected function removeList($name)
+    {
+        return $this->cache->del($name);
+    }
+
+    protected function removeListItem($name, $key)
+    {
+        return $this->cache->lrem($name, $key, 0);
+    }
 }

composer.json

@@ -34,7 +34,7 @@
     },
     "require-dev":       {
         "phpunit/phpunit":         "^4.0|^5.1",
-        "cache/integration-tests": "0.7.0"
+        "cache/integration-tests": "0.9.0"
     },
     "provide":           {
         "psr/cache-implementation": "^1.0"