Skip to content

Commit 7768730

Browse files
committed
SeriesImportServiceImplTest: simplify unit tests by not testing the similar things in many tests.
No functional changes.
1 parent 213364c commit 7768730

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

src/test/groovy/ru/mystamps/web/service/SeriesImportServiceImplTest.groovy

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,6 @@ class SeriesImportServiceImplTest extends Specification {
442442
@SuppressWarnings([ 'ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword', 'UnnecessaryGetter' ])
443443
def 'saveParsedData() should pass data to extractor service and save its results'() {
444444
given:
445-
Integer expectedRequestId = Random.id()
446445
RawParsedDataDto expectedRawData = TestObjects.createRawParsedDataDto()
447446
SeriesExtractedInfo expectedSeriesInfo = TestObjects.createSeriesExtractedInfo()
448447
and:
@@ -452,12 +451,12 @@ class SeriesImportServiceImplTest extends Specification {
452451
Integer expectedQuantity = expectedSeriesInfo.getQuantity()
453452
Boolean expectedPerforated = expectedSeriesInfo.getPerforated()
454453
when:
455-
service.saveParsedData(expectedRequestId, expectedRawData)
454+
service.saveParsedData(Random.id(), expectedRawData)
456455
then:
457456
1 * extractorService.extract(expectedRawData) >> expectedSeriesInfo
458457
and:
459458
1 * seriesImportDao.addParsedData(
460-
expectedRequestId,
459+
_ as Integer,
461460
{ AddSeriesParsedDataDbDto parsedData ->
462461
assert parsedData?.categoryId == expectedCategoryId
463462
assert parsedData?.countryId == expectedCountryId
@@ -472,14 +471,12 @@ class SeriesImportServiceImplTest extends Specification {
472471
@SuppressWarnings('UnnecessaryReturnKeyword')
473472
def 'saveParsedData() should change request status'() {
474473
given:
475-
Integer expectedRequestId = Random.id()
476-
and:
477474
extractorService.extract(_ as RawParsedDataDto) >> TestObjects.createEmptySeriesExtractedInfo()
478475
when:
479-
service.saveParsedData(expectedRequestId, TestObjects.createRawParsedDataDto())
476+
service.saveParsedData(Random.id(), TestObjects.createRawParsedDataDto())
480477
then:
481478
1 * seriesImportDao.changeStatus(
482-
expectedRequestId,
479+
_ as Integer,
483480
{ Date date ->
484481
assert DateUtils.roughlyEqual(date, new Date())
485482
return true

0 commit comments

Comments
 (0)