[+]: fixes reported by phpstorm

Author: voku

src/EDI/Analyser.php

@@ -33,14 +33,11 @@ public function loadMessageXml(string $message_xml_file)
         }
 
         $messageXml = new \SimpleXMLIterator($messageXmlString);
-        unset($messageXmlString);
-        $message = [
+
+        return [
             'defaults' => $this->readMessageDefaults($messageXml),
             'segments' => $this->readXmlNodes($messageXml),
         ];
-        unset($messageXml);
-
-        return $message;
     }
 
     /**
@@ -58,7 +55,6 @@ public function loadCodesXml(string $codesXml)
         }
 
         $codesXml = new \SimpleXMLIterator($codesXmlString);
-        unset($codesXmlString);
         $codes = [];
         foreach ($codesXml as $codeCollection) {
             \assert($codeCollection instanceof \SimpleXMLIterator);
@@ -111,12 +107,14 @@ public function loadSegmentsXml(string $segment_xml_file)
         $segments_xml = null;
 
         foreach ($xml as $segmentNode) {
+            \assert($segmentNode instanceof \SimpleXMLElement);
 
-            /** @noinspection PhpSillyAssignmentInspection - hack for phpstan */
-            /* @var \SimpleXMLElement $segmentNode */
-            $segmentNode = $segmentNode;
+            $segmentNodeAttributes = $segmentNode->attributes();
+            if ($segmentNodeAttributes === null) {
+                continue;
+            }
 
-            $qualifier = (string) $segmentNode->attributes()->id;
+            $qualifier = (string) $segmentNodeAttributes->id;
             $segment = [];
             $segment['attributes'] = $this->readAttributesArray($segmentNode);
             $details = $this->readXmlNodes($segmentNode);
@@ -193,7 +191,7 @@ public function process(array $data, array $rawSegments = null): string
                                     $r[] = '        length: ' . $d_sub_desc_attr['length'];
                                 }
 
-                                //check for skipped data
+                                // check for skipped data
                                 unset(
                                     $d_sub_desc_attr['id'],
                                     $d_sub_desc_attr['name'],

src/EDI/Encoder.php

@@ -119,14 +119,18 @@ public function encodeSegment(array $row): string
         $str = '';
         $t = \count($row);
 
+        /** @noinspection AlterInForeachInspection */
         foreach ($row as $i => &$iValue) {
             if (\is_array($iValue)) {
-                if (\count($iValue) === 1
-                    && \is_array(\reset($iValue))
+                if (
+                    \count($iValue) === 1
+                    &&
+                    \is_array(\reset($iValue))
                 ) {
                     $iValue = \array_pop($iValue);
                 }
 
+                /** @noinspection NotOptimalIfConditionsInspection */
                 if (\is_array($iValue)) {
                     foreach ($iValue as &$temp) {
                         $temp = $this->escapeValue($temp);
@@ -145,7 +149,6 @@ public function encodeSegment(array $row): string
             }
             $str .= $this->sepData;
         }
-        unset($iValue);
 
         $str .= $this->symbEnd;
 
@@ -182,11 +185,7 @@ public function get(): string
      */
     public function setUNA(string $chars, bool $user_call = true): bool
     {
-        if (
-            \is_string($chars)
-            &&
-            \strlen($chars) == 6
-        ) {
+        if (\strlen($chars) == 6) {
             $this->sepComp = $chars[0];
             $this->sepData = $chars[1];
             $this->sepDec = $chars[2];

src/EDI/Parser.php

@@ -342,11 +342,14 @@ public function getRawSegments()
      *
      * @param string $url
      *
-     * @return array
+     * @return array|false
      */
-    public function load($url): array
+    public function load($url)
     {
         $file = \file_get_contents($url);
+        if ($file === false) {
+            return false;
+        }
 
         return $this->loadString($file);
     }
@@ -533,13 +536,21 @@ private function splitSegment(string &$str): array
             //
             // Question mark is represented by ??
 
-            if ($this->symbEnd && \strpos($value, $this->symbEnd) !== false) {
+            if (
+                $this->symbEnd
+                &&
+                \strpos($value, $this->symbEnd) !== false
+            ) {
                 if (\preg_match(self::$DELIMITER . '(?<!' . $this->symbRel . ')' . $this->symbEnd . self::$DELIMITER, $value)) {
                     $this->errors[] = "There's a " . \stripslashes($this->symbEnd) . ' not escaped in the data; string ' . $str;
                 }
             }
 
-            if ($this->symbUnescapedRel && \strpos($value, $this->symbUnescapedRel) !== false) {
+            if (
+                $this->symbUnescapedRel
+                &&
+                \strpos($value, $this->symbUnescapedRel) !== false
+            ) {
                 if (\preg_match(self::$DELIMITER . '(?<!' . $this->symbRel . ')' . $this->symbRel . '(?!' . $this->symbRel . ')(?!' . $this->sepData . ')(?!' . $this->sepComp . ')(?!' . $this->symbEnd . ')' . self::$DELIMITER, $value)) {
                     $this->errors[] = "There's a character not escaped with " . \stripslashes($this->symbRel ?? '') . ' in the data; string ' . $value;
                 }
@@ -548,7 +559,6 @@ private function splitSegment(string &$str): array
             // split on "sepComp"
             $value = $this->splitData($value);
         }
-        unset($value);
 
         return $matches;
     }

src/EDI/Reader.php

@@ -216,6 +216,7 @@ public function readEdiDataValue($filter, int $l1, $l2 = false, bool $required =
             $filter_elements = false;
         }
 
+        // init
         $segment = false;
         $segment_count = 0;