Skip to content

Commit ef45ba6

Browse files
committed
Fix client api version to 2.4
1 parent b9ba56b commit ef45ba6

File tree

6 files changed

+20
-26
lines changed

6 files changed

+20
-26
lines changed

.github/workflows/phpstan-9.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: PHPStan level 8
1+
name: PHPStan level 9
22
on: push
33
jobs:
44
phpstan-9:

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"psr/log": "^3.0",
2323
"nyholm/psr7": "^1.5",
2424
"php-etl/bucket": "*",
25-
"php-etl/magento2-api-client": "^0.1.0",
25+
"php-etl/magento2-api-client": "2.4.x-dev",
2626
"psr/simple-cache": "^3.0",
2727
"php-etl/mapping-contracts": "0.4.*"
2828
},

composer.lock

Lines changed: 14 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/CustomerExtractor.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
use Kiboko\Component\Bucket\AcceptanceResultBucket;
88
use Kiboko\Component\Bucket\RejectionResultBucket;
99
use Kiboko\Contract\Bucket\RejectionResultBucketInterface;
10-
use Kiboko\Contract\Bucket\ResultBucketInterface;
1110
use Kiboko\Contract\Pipeline\ExtractorInterface;
1211
use Kiboko\Magento\Client;
1312
use Kiboko\Magento\Exception\GetV1CustomersSearchInternalServerErrorException;

src/FilterGroup.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,9 @@ public function withFilter(FilterInterface $filter): self
1919
return $this;
2020
}
2121

22-
public function withFilters(FilterInterface ...$filter): self
22+
public function withFilters(FilterInterface ...$filters): self
2323
{
24-
foreach ($filter as $item) {
25-
$this->filters[] = $item;
26-
}
24+
array_push($this->filters, ...$filters);
2725

2826
return $this;
2927
}

src/QueryParameters.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,9 @@ public function withGroup(FilterGroup $group): self
1616
return $this;
1717
}
1818

19-
public function withGroups(FilterGroup ...$group): self
19+
public function withGroups(FilterGroup ...$groups): self
2020
{
21-
foreach ($group as $item) {
22-
$this->groups[] = $item;
23-
}
21+
array_push($this->groups, ...$groups);
2422

2523
return $this;
2624
}

0 commit comments

Comments
 (0)