[rector] Rector fixes

Author: actions-user

.github/workflows/quality.yaml

@@ -60,5 +60,5 @@ jobs:
         uses: php-actions/phpstan@v3
         with:
           path: src/
-          level: 4
+          level: 3
           php_version: '8.2'

.gitignore

@@ -2,3 +2,5 @@
 /vendor/
 bin/
 .php-cs-fixer.cache
+.phpunit.result.cache
+.phpunit.cache/

composer.json

@@ -4,7 +4,7 @@
     "type": "library",
     "require": {
         "php": "^8.2",
-        "phpunit/phpunit": "^10",
+        "phpunit/phpunit": "^10.0",
         "nikic/php-parser": "^4.10",
         "php-etl/pipeline-contracts": "^0.3.0",
         "php-http/message": "^1.11",

composer.lock

@@ -0,0 +1,23 @@
+{
+    "$schema": "https://raw.githubusercontent.com/infection/infection/0.26.18/resources/schema.json",
+    "source": {
+        "directories": [
+            "src"
+        ]
+    },
+    "timeout": 10,
+    "logs": {
+        "text": "infection.log",
+        "summary": "summary.log",
+        "json": "infection-log.json",
+        "perMutator": "per-mutator.md",
+        "github": true,
+    },
+    "phpUnit": {
+        "configDir": "."
+    },
+    "mutators": {
+        "@default": true
+    },
+    "testFramework":"phpunit",
+}

infection.json5

@@ -1,31 +1,32 @@
 <?xml version="1.0"?>
 <phpunit
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-        xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
+        xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.0/phpunit.xsd"
         backupGlobals="true"
-        backupStaticAttributes="false"
         colors="false"
-        convertErrorsToExceptions="true"
-        convertNoticesToExceptions="true"
-        convertWarningsToExceptions="true"
-        forceCoversAnnotation="false"
         processIsolation="false"
         stopOnError="false"
         stopOnFailure="false"
         stopOnIncomplete="false"
         stopOnSkipped="false"
         stopOnRisky="false"
-        testSuiteLoaderClass="PHPUnit\Runner\StandardTestSuiteLoader"
         timeoutForSmallTests="1"
         timeoutForMediumTests="10"
         timeoutForLargeTests="60"
-        verbose="false">
-    <testsuites>
-        <testsuite name="Functional tests">
-            <directory>tests/functional/</directory>
-        </testsuite>
-    </testsuites>
-    <php>
-        <ini name="allow_url_include" value="1" />
-    </php>
+        cacheDirectory=".phpunit.cache"
+        backupStaticProperties="false"
+        requireCoverageMetadata="false">
+  <testsuites>
+    <testsuite name="Functional tests">
+      <directory>tests/functional/</directory>
+    </testsuite>
+  </testsuites>
+  <coverage>
+    <include>
+      <directory suffix=".php">src</directory>
+    </include>
+  </coverage>
+  <php>
+    <ini name="allow_url_include" value="1"/>
+  </php>
 </phpunit>

phpunit.xml

@@ -3,13 +3,14 @@
 namespace functional\Constraint\Pipeline;
 
 use Kiboko\Component\PHPUnitExtension\Constraint\Pipeline\IteratesLike;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Constraint\IsEqual;
 use PHPUnit\Framework\Constraint\LogicalNot;
 use PHPUnit\Framework\TestCase;
 
 final class IteratesLikeTest extends TestCase
 {
-    private $fixtures = <<<JSON
+    private static string $fixtures = <<<JSON
             {"firstName":"Margot","lastName":"Lamy","email":"[email protected]","address":"39, chemin Huet\\r\\n76 185 Gomez","postcode":"84 138","city":"Legrand"}
             {"firstName":"Dominique","lastName":"Garnier","email":"[email protected]","address":"46, chemin de Hernandez\\r\\n52 853 Munoz","postcode":"95 866","city":"BuissonBourg"}
             {"firstName":"Mich\\u00e8le","lastName":"Martins","email":"[email protected]","address":"374, rue de Gauthier\\r\\n82315 LaineBourg","postcode":"89 150","city":"Aubry"}
@@ -80,22 +81,22 @@ final class IteratesLikeTest extends TestCase
             {"firstName":"No\\u00e9mi","lastName":"Guillaume","email":"[email protected]","address":"757, rue Mich\\u00e8le Gay\\r\\n65212 Leroux","postcode":"95030","city":"Ruiz"}
             JSON;
 
-    private function fromJSONStream(string $source): iterable
+    private static function fromJSONStream(string $source): iterable
     {
         $file = new \SplFileObject('php://temp', 'r+');
         $file->fwrite($source);
         $file->fseek(0, SEEK_SET);
 
         while (!$file->eof()) {
-            yield \json_decode($file->fgets(), true);
+            yield \json_decode($file->fgets(), true, 512, JSON_THROW_ON_ERROR);
         }
     }
 
-    public function successfulDataProvider()
+    public static function successfulDataProvider(): \Generator
     {
         yield [
-            $this->fromJSONStream($this->fixtures),
-            $this->fromJSONStream($this->fixtures),
+            IteratesLikeTest::fromJSONStream(self::$fixtures),
+            IteratesLikeTest::fromJSONStream(self::$fixtures),
         ];
 
         yield [
@@ -104,7 +105,7 @@ public function successfulDataProvider()
         ];
     }
 
-    /** @dataProvider successfulDataProvider */
+    #[DataProvider('successfulDataProvider')]
     public function testExtractionSucceeds(iterable $expected, iterable $actual)
     {
         $constraint = new IteratesLike($expected, fn ($value) => new IsEqual($value));
@@ -114,7 +115,7 @@ public function testExtractionSucceeds(iterable $expected, iterable $actual)
 
     public function testExtractionFails()
     {
-        $constraint = new IteratesLike($this->fromJSONStream($this->fixtures), fn ($value) => new LogicalNot(new IsEqual($value)));
+        $constraint = new IteratesLike(IteratesLikeTest::fromJSONStream(self::$fixtures), fn ($value) => new LogicalNot(new IsEqual($value)));
 
         $this->assertThat([], $constraint);
     }