Skip to content

Commit 862da99

Browse files
committed
Updated tests + fixed PhpStan errors
1 parent 5ac1548 commit 862da99

File tree

5 files changed

+17
-5
lines changed

5 files changed

+17
-5
lines changed

src/Sheet/Safe/Loader.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
use Box\Spout\Writer\Exception\WriterNotOpenedException;
1111
use Box\Spout\Writer\WriterInterface;
1212
use Kiboko\Component\Bucket\AcceptanceResultBucket;
13+
use Kiboko\Component\Bucket\EmptyResultBucket;
14+
use Kiboko\Contract\Bucket\ResultBucketInterface;
15+
use Kiboko\Contract\Pipeline\FlushableInterface;
1316
use Kiboko\Contract\Pipeline\LoaderInterface;
1417
use Psr\Log\LoggerInterface;
1518
use Psr\Log\NullLogger;
@@ -24,7 +27,7 @@ public function __construct(
2427

2528
public function load(): \Generator
2629
{
27-
$line = yield;
30+
$line = yield new EmptyResultBucket();
2831
$headers = array_keys($line);
2932
try {
3033
$this->writer->addRow(
@@ -36,6 +39,7 @@ public function load(): \Generator
3639
return;
3740
}
3841

42+
/* @phpstan-ignore-next-line */
3943
while (true) {
4044
try {
4145
$this->writer->addRow($this->orderColumns($headers, $line));

tests/functional/Sheet/FingersCrossed/ExcelLoaderTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,11 @@ public function load(): void
7474
'last name' => 'dupont',
7575
],
7676
],
77-
new Loader($this->writer, 'Sheet1')
77+
new Loader($this->writer)
7878
);
7979

80+
$this->writer->close();
81+
8082
$this->assertRowWasWrittenToExcel(
8183
/* 'vfs://test.xlsx' */ $path,
8284
'Sheet1',

tests/functional/Sheet/FingersCrossed/OpenDocumentLoaderTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,11 @@ public function load(): void
7474
'last name' => 'dupont',
7575
],
7676
],
77-
new Loader($this->writer, 'Sheet1')
77+
new Loader($this->writer)
7878
);
7979

80+
$this->writer->close();
81+
8082
$this->assertRowWasWrittenToOpenDocument(
8183
/* 'vfs://test.ods' */ $path,
8284
'Sheet1',

tests/functional/Sheet/Safe/ExcelLoaderTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,11 @@ public function load(): void
7474
'last name' => 'dupont',
7575
],
7676
],
77-
new Loader($this->writer, 'Sheet1')
77+
new Loader($this->writer)
7878
);
7979

80+
$this->writer->close();
81+
8082
$this->assertRowWasWrittenToExcel(
8183
/* 'vfs://test.xlsx' */ $path,
8284
'Sheet1',

tests/functional/Sheet/Safe/OpenDocumentLoaderTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,11 @@ public function load(): void
7474
'last name' => 'dupont',
7575
],
7676
],
77-
new Loader($this->writer, 'Sheet1')
77+
new Loader($this->writer)
7878
);
7979

80+
$this->writer->close();
81+
8082
$this->assertRowWasWrittenToOpenDocument(
8183
/* 'vfs://test.ods' */ $path,
8284
'Sheet1',

0 commit comments

Comments
 (0)