Skip to content

Commit fc5cb8c

Browse files
committed
Updated tests + fixed PhpStan errors
1 parent 5ac1548 commit fc5cb8c

File tree

5 files changed

+15
-5
lines changed

5 files changed

+15
-5
lines changed

src/Sheet/Safe/Loader.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
use Box\Spout\Writer\Exception\WriterNotOpenedException;
1111
use Box\Spout\Writer\WriterInterface;
1212
use Kiboko\Component\Bucket\AcceptanceResultBucket;
13+
use Kiboko\Component\Bucket\EmptyResultBucket;
1314
use Kiboko\Contract\Pipeline\LoaderInterface;
1415
use Psr\Log\LoggerInterface;
1516
use Psr\Log\NullLogger;
@@ -24,7 +25,7 @@ public function __construct(
2425

2526
public function load(): \Generator
2627
{
27-
$line = yield;
28+
$line = yield new EmptyResultBucket();
2829
$headers = array_keys($line);
2930
try {
3031
$this->writer->addRow(
@@ -36,6 +37,7 @@ public function load(): \Generator
3637
return;
3738
}
3839

40+
/* @phpstan-ignore-next-line */
3941
while (true) {
4042
try {
4143
$this->writer->addRow($this->orderColumns($headers, $line));

tests/functional/Sheet/FingersCrossed/ExcelLoaderTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,11 @@ public function load(): void
7474
'last name' => 'dupont',
7575
],
7676
],
77-
new Loader($this->writer, 'Sheet1')
77+
new Loader($this->writer)
7878
);
7979

80+
$this->writer->close();
81+
8082
$this->assertRowWasWrittenToExcel(
8183
/* 'vfs://test.xlsx' */ $path,
8284
'Sheet1',

tests/functional/Sheet/FingersCrossed/OpenDocumentLoaderTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,11 @@ public function load(): void
7474
'last name' => 'dupont',
7575
],
7676
],
77-
new Loader($this->writer, 'Sheet1')
77+
new Loader($this->writer)
7878
);
7979

80+
$this->writer->close();
81+
8082
$this->assertRowWasWrittenToOpenDocument(
8183
/* 'vfs://test.ods' */ $path,
8284
'Sheet1',

tests/functional/Sheet/Safe/ExcelLoaderTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,11 @@ public function load(): void
7474
'last name' => 'dupont',
7575
],
7676
],
77-
new Loader($this->writer, 'Sheet1')
77+
new Loader($this->writer)
7878
);
7979

80+
$this->writer->close();
81+
8082
$this->assertRowWasWrittenToExcel(
8183
/* 'vfs://test.xlsx' */ $path,
8284
'Sheet1',

tests/functional/Sheet/Safe/OpenDocumentLoaderTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,11 @@ public function load(): void
7474
'last name' => 'dupont',
7575
],
7676
],
77-
new Loader($this->writer, 'Sheet1')
77+
new Loader($this->writer)
7878
);
7979

80+
$this->writer->close();
81+
8082
$this->assertRowWasWrittenToOpenDocument(
8183
/* 'vfs://test.ods' */ $path,
8284
'Sheet1',

0 commit comments

Comments
 (0)