Use ZEND_BYTES_SWAP32() for php_pack_reverse_int32()

nielsdos · nielsdos · commit 18a385faaa94 · 2025-06-12T19:24:06.000+02:00
diff --git a/ext/standard/pack.c b/ext/standard/pack.c
@@ -76,10 +76,7 @@ ZEND_ATTRIBUTE_CONST static inline uint16_t php_pack_reverse_int16(uint16_t arg)
 /* {{{ php_pack_reverse_int32 */
 ZEND_ATTRIBUTE_CONST static inline uint32_t php_pack_reverse_int32(uint32_t arg)
 {
-	uint32_t result;
-	result = ((arg & 0xFF) << 24) | ((arg & 0xFF00) << 8) | ((arg >> 8) & 0xFF00) | ((arg >> 24) & 0xFF);
-
-	return result;
+	return ZEND_BYTES_SWAP32(arg);
 }
 /* }}} */
 

Original file line number	Diff line number	Diff line change
`@@ -76,10 +76,7 @@ ZEND_ATTRIBUTE_CONST static inline uint16_t php_pack_reverse_int16(uint16_t arg)`
`76`	`76`	`/* {{{ php_pack_reverse_int32 */`
`77`	`77`	`ZEND_ATTRIBUTE_CONST static inline uint32_t php_pack_reverse_int32(uint32_t arg)`
`78`	`78`	`{`
`79`		`- uint32_t result;`
`80`		`- result = ((arg & 0xFF) << 24) \| ((arg & 0xFF00) << 8) \| ((arg >> 8) & 0xFF00) \| ((arg >> 24) & 0xFF);`
`81`		`-`
`82`		`- return result;`
	`79`	`+ return ZEND_BYTES_SWAP32(arg);`
`83`	`80`	`}`
`84`	`81`	`/* }}} */`
`85`	`82`