Fix tests

Author: kocsismate

Zend/tests/bug21478.phpt

@@ -3,7 +3,7 @@ Bug #21478 (Zend/zend_alloc.c :: shutdown_memory_manager produces segfault)
 --FILE--
 <?php
 class debugfilter extends php_user_filter {
-  function filter($in, $out, &$consumed, $closing) {
+  function filter($in, $out, &$consumed, $closing): int {
     while ($bucket = stream_bucket_make_writeable($in)) {
       $bucket->data = strtoupper($bucket->data);
       stream_bucket_append($out, $bucket);

Zend/tests/bug78406.phpt

@@ -10,7 +10,7 @@ if (!class_exists(SampleFilter::class)) {
     {
         private $data = '';
 
-        public function filter($in, $out, &$consumed, $closing)
+        public function filter($in, $out, &$consumed, $closing): int
         {
             while ($bucket = stream_bucket_make_writeable($in))
             {

Zend/tests/enum/json_encode.phpt

@@ -18,7 +18,7 @@ enum StringFoo: string {
 enum CustomFoo implements JsonSerializable {
     case Bar;
 
-    public function jsonSerialize() {
+    public function jsonSerialize(): mixed {
         return 'Custom ' . $this->name;
     }
 }

Zend/tests/foreach_004.phpt

@@ -16,10 +16,26 @@ class IT extends ArrayIterator {
         }
     }
 
-    function rewind()  {$this->trap(__FUNCTION__); return parent::rewind();}
-    function valid()   {$this->trap(__FUNCTION__); return parent::valid();}
-    function key()     {$this->trap(__FUNCTION__); return parent::key();}
-    function next()    {$this->trap(__FUNCTION__); return parent::next();}
+    function rewind(): void
+    {
+        $this->trap(__FUNCTION__);
+        parent::rewind();
+    }
+
+    function valid(): bool {
+        $this->trap(__FUNCTION__);
+        return parent::valid();
+    }
+
+    function key(): mixed {
+        $this->trap(__FUNCTION__);
+        return parent::key();
+    }
+
+    function next(): void {
+        $this->trap(__FUNCTION__);
+        parent::next();
+    }
 }
 
 foreach(['rewind', 'valid', 'key', 'next'] as $trap) {

Zend/tests/iterator_key_by_ref.phpt

@@ -3,7 +3,7 @@ Iterator::key() with by-ref return
 --FILE--
 <?php
 class Test extends ArrayIterator {
-    function &key() {
+    function &key(): mixed {
         return $foo;
     }
 }

Zend/tests/ns_054.phpt

@@ -5,18 +5,18 @@
 namespace test\ns1;
 
 class Foo implements \SplObserver {
-    function update(\SplSubject $x) {
+    function update(\SplSubject $x): void {
         echo "ok\n";
     }
 }
 
 class Bar implements \SplSubject {
-    function attach(\SplObserver $x) {
+    function attach(\SplObserver $x): void {
         echo "ok\n";
     }
-    function notify() {
+    function notify(): void {
     }
-    function detach(\SplObserver $x) {
+    function detach(\SplObserver $x): void {
     }
 }
 $foo = new Foo();

Zend/tests/ns_056.phpt

@@ -6,18 +6,18 @@ namespace test\ns1;
 use \SplObserver;
 
 class Foo implements SplObserver {
-    function update(\SplSubject $x) {
+    function update(\SplSubject $x): void {
         echo "ok\n";
     }
 }
 
 class Bar implements \SplSubject {
-    function attach(SplObserver $x) {
+    function attach(SplObserver $x): void {
         echo "ok\n";
     }
-    function notify() {
+    function notify(): void {
     }
-    function detach(SplObserver $x) {
+    function detach(SplObserver $x): void {
     }
 }
 $foo = new Foo();

Zend/tests/parameter_default_values/internal_declaration_error_class_const.phpt

@@ -4,10 +4,10 @@ The default value is a class constant in the parent class method's signature.
 <?php
 class MyDateTimeZone extends DateTimeZone
 {
-    public static function listIdentifiers()
+    public static function listIdentifiers(): array
     {
     }
 }
 ?>
 --EXPECTF--
-Fatal error: Declaration of MyDateTimeZone::listIdentifiers() must be compatible with DateTimeZone::listIdentifiers(int $timezoneGroup = DateTimeZone::ALL, ?string $countryCode = null) in %s on line %d
+Fatal error: Declaration of MyDateTimeZone::listIdentifiers(): array must be compatible with DateTimeZone::listIdentifiers(int $timezoneGroup = DateTimeZone::ALL, ?string $countryCode = null): array in %s on line %d

Zend/tests/parameter_default_values/internal_declaration_error_const.phpt

@@ -4,10 +4,10 @@ The default value is a constant in the parent class method's signature.
 <?php
 class MyDateTimeZone extends DateTimeZone
 {
-    public function getTransitions()
+    public function getTransitions(): array|false
     {
     }
 }
 ?>
 --EXPECTF--
-Fatal error: Declaration of MyDateTimeZone::getTransitions() must be compatible with DateTimeZone::getTransitions(int $timestampBegin = PHP_INT_MIN, int $timestampEnd = PHP_INT_MAX) in %s on line %d
+Fatal error: Declaration of MyDateTimeZone::getTransitions(): array|false must be compatible with DateTimeZone::getTransitions(int $timestampBegin = PHP_INT_MIN, int $timestampEnd = PHP_INT_MAX): array|false in %s on line %d

Zend/tests/parameter_default_values/internal_declaration_error_false.phpt

@@ -5,8 +5,8 @@ The default value is false in the parent class method's signature.
 
 interface MyDateTimeInterface extends DateTimeInterface
 {
-    public function diff();
+    public function diff(): DateInterval|false;
 }
 ?>
 --EXPECTF--
-Fatal error: Declaration of MyDateTimeInterface::diff() must be compatible with DateTimeInterface::diff(DateTimeInterface $targetObject, bool $absolute = false) in %s on line %d
+Fatal error: Declaration of MyDateTimeInterface::diff(): DateInterval|false must be compatible with DateTimeInterface::diff(DateTimeInterface $targetObject, bool $absolute = false): DateInterval|false in %s on line %d