Deprecate strftime() and gmstrftime()

These are deprecated in favor of date()/DateTime::format() (for
locale-indendent formatting) and IntlDateFormatter::format()
(for locale-dependent formatting).

Part of https://wiki.php.net/rfc/deprecations_php_8_1.

Author: nikic

UPGRADING

@@ -359,6 +359,9 @@ PHP 8.1 UPGRADE NOTES
   . The date_sunrise() and date_sunset() functions have been deprecated in
     favor of date_sun_info().
     RFC: https://wiki.php.net/rfc/deprecations_php_8_1
+  . The strftime() and gmstrftime() functions have been deprecated in favor of
+    date()/DateTime::format() (for locale-independent formatting) or
+    IntlDateFormatter::format() (for locale-dependent formatting).
 
 - Filter:
   . The FILTER_SANITIZE_STRING and FILTER_SANITIZE_STRIPPED filters have been

ext/date/php_date.stub.php

@@ -20,8 +20,10 @@ function gmmktime(
 
 function checkdate(int $month, int $day, int $year): bool {}
 
+/** @deprecated */
 function strftime(string $format, ?int $timestamp = null): string|false {}
 
+/** @deprecated */
 function gmstrftime(string $format, ?int $timestamp = null): string|false {}
 
 function time(): int {}

ext/date/php_date_arginfo.h

@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: fbec11a67d5cc04667a012f25894f0d9e18833a6 */
+ * Stub hash: bc0634c149cda640616f7ecd7e173a0d6497a911 */
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_strtotime, 0, 1, MAY_BE_LONG|MAY_BE_FALSE)
 	ZEND_ARG_TYPE_INFO(0, datetime, IS_STRING, 0)
@@ -559,8 +559,8 @@ static const zend_function_entry ext_functions[] = {
 	ZEND_FE(mktime, arginfo_mktime)
 	ZEND_FE(gmmktime, arginfo_gmmktime)
 	ZEND_FE(checkdate, arginfo_checkdate)
-	ZEND_FE(strftime, arginfo_strftime)
-	ZEND_FE(gmstrftime, arginfo_gmstrftime)
+	ZEND_DEP_FE(strftime, arginfo_strftime)
+	ZEND_DEP_FE(gmstrftime, arginfo_gmstrftime)
 	ZEND_FE(time, arginfo_time)
 	ZEND_FE(localtime, arginfo_localtime)
 	ZEND_FE(getdate, arginfo_getdate)

ext/date/tests/009.phpt

@@ -23,14 +23,29 @@ var_dump(gmstrftime("blah", $t));
 echo "Done\n";
 ?>
 --EXPECTF--
+Deprecated: Function strftime() is deprecated in %s on line %d
 bool(false)
+
+Deprecated: Function strftime() is deprecated in %s on line %d
 string(%d) "Tue Tuesday Jun June Tue Jun 27 00:00:00 2006 %s
 %s %"
+
+Deprecated: Function strftime() is deprecated in %s on line %d
 string(5) "%q %a"
+
+Deprecated: Function strftime() is deprecated in %s on line %d
 string(4) "blah"
+
+Deprecated: Function gmstrftime() is deprecated in %s on line %d
 bool(false)
+
+Deprecated: Function gmstrftime() is deprecated in %s on line %d
 string(%d) "Mon Monday Jun June Mon Jun 26 21:00:00 2006 %s
 %s %"
+
+Deprecated: Function gmstrftime() is deprecated in %s on line %d
 string(5) "%q %a"
+
+Deprecated: Function gmstrftime() is deprecated in %s on line %d
 string(4) "blah"
 Done

ext/date/tests/009_win32.phpt

@@ -35,12 +35,27 @@ echo "Done\n";
 setlocale(LC_TIME, $loc);
 ?>
 --EXPECTF--
+Deprecated: Function strftime() is deprecated in %s on line %d
 bool(false)
+
+Deprecated: Function strftime() is deprecated in %s on line %d
 string(%d) "Tue Tuesday Jun June 6/27/2006 12:00:00 AM 27 00 12 178 06 00 AM 00 26 26 2 6/27/2006 12:00:00 AM 06 2006 %s"
+
+Deprecated: Function strftime() is deprecated in %s on line %d
 string(5) "%q %a"
+
+Deprecated: Function strftime() is deprecated in %s on line %d
 string(4) "blah"
+
+Deprecated: Function gmstrftime() is deprecated in %s on line %d
 bool(false)
+
+Deprecated: Function gmstrftime() is deprecated in %s on line %d
 string(%d) "Mon Monday Jun June 6/26/2006 9:00:00 PM 26 21 09 177 06 00 PM 00 26 26 1 6/26/2006 9:00:00 PM 06 2006 %s"
+
+Deprecated: Function gmstrftime() is deprecated in %s on line %d
 string(5) "%q %a"
+
+Deprecated: Function gmstrftime() is deprecated in %s on line %d
 string(4) "blah"
 Done

ext/date/tests/bug33532.phpt

@@ -6,7 +6,7 @@ date.timezone=UTC
 --SKIPIF--
 <?php
 if(PHP_OS == 'Darwin' || defined('PHP_WINDOWS_VERSION_MAJOR')) die("skip strftime uses system TZ on Darwin and Windows");
-if (!strftime('%Z')) die('skip strftime does not support %Z');
+if (!@strftime('%Z')) die('skip strftime does not support %Z');
 ?>
 --FILE--
 <?php

ext/date/tests/bug65184.phpt

@@ -8,6 +8,7 @@ if (strtoupper(substr(PHP_OS, 0, 3)) != 'WIN') {
 ?>
 --INI--
 date.timezone = UTC
+error_reporting=E_ALL&~E_DEPRECATED
 --FILE--
 <?php
     setlocale(LC_ALL, 'Japanese_Japan.932');

ext/date/tests/bug65371.phpt

@@ -16,8 +16,12 @@ function p($str)
 setlocale(LC_ALL, 'C');
 p('あ');
 ?>
---EXPECT--
+--EXPECTF--
 あ
+
+Deprecated: Function strftime() is deprecated in %s on line %d
 あ
 e38182
+
+Deprecated: Function strftime() is deprecated in %s on line %d
 e38182

ext/date/tests/gmstrftime_basic.phpt

@@ -17,5 +17,9 @@ var_dump( gmstrftime($format) );
 ?>
 --EXPECTF--
 *** Testing gmstrftime() : basic functionality ***
+
+Deprecated: Function gmstrftime() is deprecated in %s on line %d
 string(20) "Aug 08 2008 08:08:08"
+
+Deprecated: Function gmstrftime() is deprecated in %s on line %d
 string(%d) "%s %d %d %d:%d:%d"

ext/date/tests/gmstrftime_variation10.phpt

@@ -34,9 +34,17 @@ foreach($inputs as $key =>$value) {
 *** Testing gmstrftime() : usage variation ***
 
 --The ISO 8601:1988 week number--
+
+Deprecated: Function gmstrftime() is deprecated in %s on line %d
 string(%d) "%d"
+
+Deprecated: Function gmstrftime() is deprecated in %s on line %d
 string(2) "32"
 
 --Weekday as decimal--
+
+Deprecated: Function gmstrftime() is deprecated in %s on line %d
 string(%d) "%d"
+
+Deprecated: Function gmstrftime() is deprecated in %s on line %d
 string(1) "5"