Skip to content

Commit 68ae477

Browse files
authored
Autotools: Quote M4 arguments (#15033)
- PHP_ADD_INCLUDE - PHP_EVAL_INCLINE - PHP_EVAL_LIBLINE
1 parent 39b1006 commit 68ae477

File tree

25 files changed

+76
-76
lines changed

25 files changed

+76
-76
lines changed

build/php.m4

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ AC_DEFUN([PHP_EVAL_INCLINE],[
391391
case $ac_i in
392392
-I*[)]
393393
ac_ii=`echo $ac_i|cut -c 3-`
394-
PHP_ADD_INCLUDE($ac_ii)
394+
PHP_ADD_INCLUDE([$ac_ii])
395395
;;
396396
esac
397397
done
@@ -1781,8 +1781,8 @@ dnl
17811781
AC_DEFUN([PHP_SETUP_ICU],[
17821782
PKG_CHECK_MODULES([ICU], [icu-uc >= 50.1 icu-io icu-i18n])
17831783
1784-
PHP_EVAL_INCLINE($ICU_CFLAGS)
1785-
PHP_EVAL_LIBLINE($ICU_LIBS, $1)
1784+
PHP_EVAL_INCLINE([$ICU_CFLAGS])
1785+
PHP_EVAL_LIBLINE([$ICU_LIBS], [$1])
17861786
17871787
ICU_CFLAGS="$ICU_CFLAGS -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1"
17881788
ICU_CXXFLAGS="$ICU_CXXFLAGS -DUNISTR_FROM_CHAR_EXPLICIT=explicit -DUNISTR_FROM_STRING_EXPLICIT=explicit"
@@ -1802,8 +1802,8 @@ AC_DEFUN([PHP_SETUP_OPENSSL],[
18021802
PKG_CHECK_MODULES([OPENSSL], [openssl >= 1.1.1], [found_openssl=yes])
18031803
18041804
if test "$found_openssl" = "yes"; then
1805-
PHP_EVAL_LIBLINE($OPENSSL_LIBS, $1)
1806-
PHP_EVAL_INCLINE($OPENSSL_CFLAGS)
1805+
PHP_EVAL_LIBLINE([$OPENSSL_LIBS], [$1])
1806+
PHP_EVAL_INCLINE([$OPENSSL_CFLAGS])
18071807
ifelse([$2],[],:,[$2])
18081808
fi
18091809
])
@@ -1878,7 +1878,7 @@ AC_DEFUN([PHP_SETUP_ICONV], [
18781878
AC_DEFINE(HAVE_ICONV,1,[ ])
18791879
if test -n "$ICONV_DIR"; then
18801880
PHP_ADD_LIBRARY_WITH_PATH($iconv_lib_name, $ICONV_DIR/$PHP_LIBDIR, $1)
1881-
PHP_ADD_INCLUDE($ICONV_INCLUDE_DIR)
1881+
PHP_ADD_INCLUDE([$ICONV_INCLUDE_DIR])
18821882
fi
18831883
$2
18841884
ifelse([$3],[],,[else $3])
@@ -1893,8 +1893,8 @@ dnl
18931893
AC_DEFUN([PHP_SETUP_LIBXML], [
18941894
PKG_CHECK_MODULES([LIBXML], [libxml-2.0 >= 2.9.0])
18951895
1896-
PHP_EVAL_INCLINE($LIBXML_CFLAGS)
1897-
PHP_EVAL_LIBLINE($LIBXML_LIBS, $1)
1896+
PHP_EVAL_INCLINE([$LIBXML_CFLAGS])
1897+
PHP_EVAL_LIBLINE([$LIBXML_LIBS], [$1])
18981898
18991899
AC_DEFINE(HAVE_LIBXML, 1, [ ])
19001900
@@ -1909,8 +1909,8 @@ dnl
19091909
AC_DEFUN([PHP_SETUP_EXPAT], [
19101910
PKG_CHECK_MODULES([EXPAT], [expat])
19111911
1912-
PHP_EVAL_INCLINE($EXPAT_CFLAGS)
1913-
PHP_EVAL_LIBLINE($EXPAT_LIBS, $1)
1912+
PHP_EVAL_INCLINE([$EXPAT_CFLAGS])
1913+
PHP_EVAL_LIBLINE([$EXPAT_LIBS], [$1])
19141914
19151915
AC_DEFINE(HAVE_LIBEXPAT, 1, [ ])
19161916
])

ext/bz2/config.m4

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if test "$PHP_BZ2" != "no"; then
2424

2525
PHP_CHECK_LIBRARY(bz2, BZ2_bzerror,
2626
[
27-
PHP_ADD_INCLUDE($BZIP_DIR/include)
27+
PHP_ADD_INCLUDE([$BZIP_DIR/include])
2828
PHP_ADD_LIBRARY_WITH_PATH(bz2, $BZIP_DIR/$PHP_LIBDIR, BZ2_SHARED_LIBADD)
2929
AC_DEFINE(HAVE_BZ2,1,[ ])
3030
], [

ext/dba/config.m4

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ if test "$PHP_TCADB" != "no"; then
235235
for i in $PHP_TCADB /usr/local /usr; do
236236
if test -f "$i/include/tcadb.h"; then
237237
THIS_PREFIX=$i
238-
PHP_ADD_INCLUDE($THIS_PREFIX/include)
238+
PHP_ADD_INCLUDE([$THIS_PREFIX/include])
239239
THIS_INCLUDE=$i/include/tcadb.h
240240
break
241241
fi
@@ -266,7 +266,7 @@ if test "$PHP_LMDB" != "no"; then
266266
for i in $PHP_LMDB /usr/local /usr; do
267267
if test -f "$i/include/lmdb.h"; then
268268
THIS_PREFIX=$i
269-
PHP_ADD_INCLUDE($THIS_PREFIX/include)
269+
PHP_ADD_INCLUDE([$THIS_PREFIX/include])
270270
THIS_INCLUDE=$i/include/lmdb.h
271271
break
272272
fi

ext/enchant/config.m4

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,17 @@ if test "$PHP_ENCHANT" != "no"; then
88

99
if test "$found_enchant_2" = "yes"; then
1010

11-
PHP_EVAL_INCLINE($ENCHANT2_CFLAGS)
12-
PHP_EVAL_LIBLINE($ENCHANT2_LIBS, ENCHANT_SHARED_LIBADD)
11+
PHP_EVAL_INCLINE([$ENCHANT2_CFLAGS])
12+
PHP_EVAL_LIBLINE([$ENCHANT2_LIBS], [ENCHANT_SHARED_LIBADD])
1313

1414
AC_DEFINE(HAVE_ENCHANT_GET_VERSION, 1, [ enchant_get_version since 1.6.0 ])
1515

1616
else
1717
AC_MSG_WARN([libenchant-2 not found trying with old libenchant])
1818
PKG_CHECK_MODULES([ENCHANT], [enchant >= 1.4.2])
1919

20-
PHP_EVAL_INCLINE($ENCHANT_CFLAGS)
21-
PHP_EVAL_LIBLINE($ENCHANT_LIBS, ENCHANT_SHARED_LIBADD)
20+
PHP_EVAL_INCLINE([$ENCHANT_CFLAGS])
21+
PHP_EVAL_LIBLINE([$ENCHANT_LIBS], [ENCHANT_SHARED_LIBADD])
2222

2323
PHP_CHECK_LIBRARY(enchant, enchant_get_version,
2424
[

ext/ffi/config.m4

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ PHP_ARG_WITH([ffi],
66
if test "$PHP_FFI" != "no"; then
77
PKG_CHECK_MODULES([FFI], [libffi >= 3.0.11])
88

9-
PHP_EVAL_INCLINE($FFI_CFLAGS)
10-
PHP_EVAL_LIBLINE($FFI_LIBS, FFI_SHARED_LIBADD)
9+
PHP_EVAL_INCLINE([$FFI_CFLAGS])
10+
PHP_EVAL_LIBLINE([$FFI_LIBS], [FFI_SHARED_LIBADD])
1111

1212
AC_DEFINE(HAVE_FFI, 1, [Have ffi support])
1313

ext/gd/config.m4

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -68,16 +68,16 @@ dnl
6868
dnl libpng is always required
6969
AC_DEFUN([PHP_GD_PNG],[
7070
PKG_CHECK_MODULES([PNG], [libpng])
71-
PHP_EVAL_LIBLINE($PNG_LIBS, GD_SHARED_LIBADD)
72-
PHP_EVAL_INCLINE($PNG_CFLAGS)
71+
PHP_EVAL_LIBLINE([$PNG_LIBS], [GD_SHARED_LIBADD])
72+
PHP_EVAL_INCLINE([$PNG_CFLAGS])
7373
AC_DEFINE(HAVE_LIBPNG, 1, [ ])
7474
])
7575

7676
AC_DEFUN([PHP_GD_AVIF],[
7777
if test "$PHP_AVIF" != "no"; then
7878
PKG_CHECK_MODULES([AVIF], [libavif >= 0.8.2])
79-
PHP_EVAL_LIBLINE($AVIF_LIBS, GD_SHARED_LIBADD)
80-
PHP_EVAL_INCLINE($AVIF_CFLAGS)
79+
PHP_EVAL_LIBLINE([$AVIF_LIBS], [GD_SHARED_LIBADD])
80+
PHP_EVAL_INCLINE([$AVIF_CFLAGS])
8181
AC_DEFINE(HAVE_LIBAVIF, 1, [ ])
8282
AC_DEFINE(HAVE_GD_AVIF, 1, [ ])
8383
fi
@@ -86,8 +86,8 @@ AC_DEFUN([PHP_GD_AVIF],[
8686
AC_DEFUN([PHP_GD_WEBP],[
8787
if test "$PHP_WEBP" != "no"; then
8888
PKG_CHECK_MODULES([WEBP], [libwebp >= 0.2.0])
89-
PHP_EVAL_LIBLINE($WEBP_LIBS, GD_SHARED_LIBADD)
90-
PHP_EVAL_INCLINE($WEBP_CFLAGS)
89+
PHP_EVAL_LIBLINE([$WEBP_LIBS], [GD_SHARED_LIBADD])
90+
PHP_EVAL_INCLINE([$WEBP_CFLAGS])
9191
AC_DEFINE(HAVE_LIBWEBP, 1, [ ])
9292
AC_DEFINE(HAVE_GD_WEBP, 1, [ ])
9393
fi
@@ -96,8 +96,8 @@ AC_DEFUN([PHP_GD_WEBP],[
9696
AC_DEFUN([PHP_GD_JPEG],[
9797
if test "$PHP_JPEG" != "no"; then
9898
PKG_CHECK_MODULES([JPEG], [libjpeg])
99-
PHP_EVAL_LIBLINE($JPEG_LIBS, GD_SHARED_LIBADD)
100-
PHP_EVAL_INCLINE($JPEG_CFLAGS)
99+
PHP_EVAL_LIBLINE([$JPEG_LIBS], [GD_SHARED_LIBADD])
100+
PHP_EVAL_INCLINE([$JPEG_CFLAGS])
101101
AC_DEFINE(HAVE_LIBJPEG, 1, [ ])
102102
AC_DEFINE(HAVE_GD_JPG, 1, [ ])
103103
fi
@@ -106,8 +106,8 @@ AC_DEFUN([PHP_GD_JPEG],[
106106
AC_DEFUN([PHP_GD_XPM],[
107107
if test "$PHP_XPM" != "no"; then
108108
PKG_CHECK_MODULES([XPM], [xpm])
109-
PHP_EVAL_LIBLINE($XPM_LIBS, GD_SHARED_LIBADD)
110-
PHP_EVAL_INCLINE($XPM_CFLAGS)
109+
PHP_EVAL_LIBLINE([$XPM_LIBS], [GD_SHARED_LIBADD])
110+
PHP_EVAL_INCLINE([$XPM_CFLAGS])
111111
AC_DEFINE(HAVE_XPM, 1, [ ])
112112
AC_DEFINE(HAVE_GD_XPM, 1, [ ])
113113
fi
@@ -117,8 +117,8 @@ AC_DEFUN([PHP_GD_FREETYPE2],[
117117
if test "$PHP_FREETYPE" != "no"; then
118118
PKG_CHECK_MODULES([FREETYPE2], [freetype2], [FREETYPE2_FOUND=true])
119119
120-
PHP_EVAL_INCLINE($FREETYPE2_CFLAGS)
121-
PHP_EVAL_LIBLINE($FREETYPE2_LIBS, GD_SHARED_LIBADD)
120+
PHP_EVAL_INCLINE([$FREETYPE2_CFLAGS])
121+
PHP_EVAL_LIBLINE([$FREETYPE2_LIBS], [GD_SHARED_LIBADD])
122122
AC_DEFINE(HAVE_LIBFREETYPE, 1, [ ])
123123
AC_DEFINE(HAVE_GD_FREETYPE, 1, [ ])
124124
fi
@@ -239,8 +239,8 @@ dnl Various checks for GD features
239239
else
240240
extra_sources="gd_compat.c"
241241
PKG_CHECK_MODULES([GDLIB], [gdlib >= 2.1.0])
242-
PHP_EVAL_LIBLINE($GDLIB_LIBS, GD_SHARED_LIBADD)
243-
PHP_EVAL_INCLINE($GDLIB_CFLAGS)
242+
PHP_EVAL_LIBLINE([$GDLIB_LIBS], [GD_SHARED_LIBADD])
243+
PHP_EVAL_INCLINE([$GDLIB_CFLAGS])
244244
AC_DEFINE(HAVE_LIBGD, 1, [ ])
245245
PHP_GD_CHECK_VERSION
246246

ext/gettext/config.m4

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ if test "$PHP_GETTEXT" != "no"; then
3535
PHP_NEW_EXTENSION(gettext, gettext.c, $ext_shared)
3636
PHP_SUBST([GETTEXT_SHARED_LIBADD])
3737

38-
PHP_ADD_INCLUDE($GETTEXT_INCDIR)
38+
PHP_ADD_INCLUDE([$GETTEXT_INCDIR])
3939

4040
AC_CHECK_LIB($GETTEXT_CHECK_IN_LIB, ngettext, [AC_DEFINE(HAVE_NGETTEXT, 1, [ ])])
4141
AC_CHECK_LIB($GETTEXT_CHECK_IN_LIB, dngettext, [AC_DEFINE(HAVE_DNGETTEXT, 1, [ ])])

ext/gmp/config.m4

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if test "$PHP_GMP" != "no"; then
2424
])
2525

2626
PHP_ADD_LIBRARY_WITH_PATH(gmp, $PHP_GMP/$PHP_LIBDIR, GMP_SHARED_LIBADD)
27-
PHP_ADD_INCLUDE($PHP_GMP/include)
27+
PHP_ADD_INCLUDE([$PHP_GMP/include])
2828
fi
2929

3030
PHP_INSTALL_HEADERS([ext/gmp], [php_gmp_int.h])

ext/ldap/config.m4

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ if test "$PHP_LDAP" != "no"; then
9191
AC_MSG_ERROR(Cannot find ldap libraries in $LDAP_LIBDIR.)
9292
fi
9393

94-
PHP_ADD_INCLUDE($LDAP_INCDIR)
94+
PHP_ADD_INCLUDE([$LDAP_INCDIR])
9595
PHP_SUBST([LDAP_SHARED_LIBADD])
9696
AC_DEFINE(HAVE_LDAP,1,[ ])
9797

@@ -131,8 +131,8 @@ if test "$PHP_LDAP" != "no"; then
131131
if test "$PHP_LDAP_SASL" != "no"; then
132132
PKG_CHECK_MODULES([SASL], [libsasl2])
133133

134-
PHP_EVAL_INCLINE($SASL_CFLAGS)
135-
PHP_EVAL_LIBLINE($SASL_LIBS, LDAP_SHARED_LIBADD)
134+
PHP_EVAL_INCLINE([$SASL_CFLAGS])
135+
PHP_EVAL_LIBLINE([$SASL_LIBS], [LDAP_SHARED_LIBADD])
136136

137137
AC_DEFINE(HAVE_LDAP_SASL, 1, [LDAP SASL support])
138138
fi

ext/mbstring/config.m4

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ EOF
5252
AC_DEFUN([PHP_MBSTRING_SETUP_MBREGEX], [
5353
if test "$PHP_MBREGEX" = "yes"; then
5454
PKG_CHECK_MODULES([ONIG], [oniguruma])
55-
PHP_EVAL_LIBLINE($ONIG_LIBS, MBSTRING_SHARED_LIBADD)
56-
PHP_EVAL_INCLINE($ONIG_CFLAGS)
55+
PHP_EVAL_LIBLINE([$ONIG_LIBS], [MBSTRING_SHARED_LIBADD])
56+
PHP_EVAL_INCLINE([$ONIG_CFLAGS])
5757
5858
AC_CACHE_CHECK([if oniguruma has an invalid entry for KOI8 encoding],
5959
[php_cv_lib_onig_invalid_koi8],

0 commit comments

Comments
 (0)