Use a proper Error to signal that [] cannot be used with SplFixedArray

Author: Girgias

ext/spl/spl_fixedarray.c

@@ -348,7 +348,7 @@ static zval *spl_fixedarray_object_read_dimension_helper(spl_fixedarray_object *
 	/* we have to return NULL on error here to avoid memleak because of
 	 * ZE duplicating uninitialized_zval_ptr */
 	if (!offset) {
-		zend_throw_exception(spl_ce_RuntimeException, "Index invalid or out of range", 0);
+		zend_throw_error(NULL, "[] operator not supported for SplFixedArray");
 		return NULL;
 	}
 
@@ -400,7 +400,7 @@ static void spl_fixedarray_object_write_dimension_helper(spl_fixedarray_object *
 
 	if (!offset) {
 		/* '$array[] = value' syntax is not supported */
-		zend_throw_exception(spl_ce_RuntimeException, "Index invalid or out of range", 0);
+		zend_throw_error(NULL, "[] operator not supported for SplFixedArray");
 		return;
 	}
 

ext/spl/tests/fixedarray_004.phpt

@@ -7,10 +7,10 @@ $a = new SplFixedArray(10);
 
 try {
     $a[] = 1;
-} catch (Exception $e) {
-    var_dump($e->getMessage());
+} catch (Error $e) {
+    echo $e->getMessage(), "\n";
 }
 
 ?>
 --EXPECT--
-string(29) "Index invalid or out of range"
+[] operator not supported for SplFixedArray

ext/spl/tests/fixedarray_006.phpt

@@ -10,13 +10,13 @@ try {
     for ($i = 0; $i < 100; $i++) {
         $a[] = new stdClass;
     }
-} catch (Exception $e) {
+} catch (Error $e) {
     echo $e->getMessage(), "\n";
 }
 
 print "ok\n";
 
 ?>
 --EXPECT--
-Index invalid or out of range
+[] operator not supported for SplFixedArray
 ok

ext/spl/tests/fixedarray_012.phpt

@@ -7,13 +7,13 @@ $a = new SplFixedArray(100);
 
 try {
     $b = &$a[];
-} catch (Exception $e) {
+} catch (Error $e) {
     echo $e->getMessage(), "\n";
 }
 
 print "ok\n";
 
 ?>
 --EXPECT--
-Index invalid or out of range
+[] operator not supported for SplFixedArray
 ok

ext/spl/tests/fixedarray_013.phpt

@@ -12,10 +12,10 @@ function test(SplFixedArray &$arr) {
 
 try {
     test($a[]);
-} catch (Exception $e) {
+} catch (\Error $e) {
     echo $e->getMessage(), "\n";
 }
 
 ?>
 --EXPECT--
-Index invalid or out of range
+[] operator not supported for SplFixedArray