Use the descriptive function name

Author: php1ic

src/io.cpp

@@ -238,11 +238,11 @@ void IO::showBanner() const
 
 std::map<std::string, std::string> IO::readOptionFile(const std::string& inputFilename) const
 {
-  std::ifstream infile(inputFilename, std::ios::binary);
-
   fmt::print("Reading {} for the input values {{--", inputFilename);
   std::map<std::string, std::string> inputfile_options;
-  if (!infile)
+
+  std::ifstream infile(inputFilename, std::ios::binary);
+  if (!infile.is_open())
     {
       fmt::print("\n***ERROR***: {} couldn't be opened, does it exist?\n", inputFilename);
 

src/massTable.cpp

@@ -59,7 +59,7 @@ bool MassTable::readAME(const std::filesystem::path& ameTable) const
 
   std::ifstream file(ameTable, std::ios::binary);
 
-  if (!file)
+  if (!file.is_open())
     {
       fmt::print("\n***ERROR***: {} couldn't be opened, does it exist?\n\n", ameTable);
       return false;
@@ -121,7 +121,7 @@ bool MassTable::readNUBASE(const std::filesystem::path& nubaseTable)
   fmt::print("Reading {} for nuclear values <--", nubaseTable);
   std::ifstream file(nubaseTable, std::ios::binary);
 
-  if (!file)
+  if (!file.is_open())
     {
       fmt::print("\n***ERROR***: {} couldn't be opened, does it exist?\n\n", nubaseTable);
       return false;
@@ -196,7 +196,7 @@ bool MassTable::readOWN(const std::filesystem::path& ownTable) const
   fmt::print("Reading {} for user selected nuclei (--", ownTable);
   std::ifstream inFile(ownTable, std::ios::binary);
 
-  if (!inFile)
+  if (!inFile.is_open())
     {
       fmt::print("\n***ERROR***: {} couldn't be opened\n\n", ownTable);
       return false;
@@ -328,6 +328,12 @@ bool MassTable::outputTableToCSV() const
   fmt::print("New file: {}\n", outfile);
   std::ofstream out(outfile);
 
+  if (!out.is_open())
+    {
+      fmt::print("\n***ERROR***: {} couldn't be opened", outfile);
+      return false;
+    }
+
   const Nuclide header("foobar");
   fmt::print(out, "{}\n", header.CSVHeader());
   for (const auto& isotope : theTable)

src/options.cpp

@@ -242,7 +242,7 @@ void Options::writeOptionFile() const
 
   fmt::print("Writing user choices to {}", options);
 
-  if (!opts)
+  if (!opts.is_open())
     {
       fmt::print("\n***ERROR***: Couldn't open {} to write the options\n"
                  "               Not creating an option file.\n",

src/rProcess.cpp

@@ -20,7 +20,7 @@ bool rProcess::readData() const
 
   std::ifstream rp(theFile, std::ios::binary);
 
-  if (!rp)
+  if (!rp.is_open())
     {
       fmt::print(stderr, "***ERROR***: {} couldn't be opened to read the r-process path\n", file);
       return false;