validateRegexPattern

Author: tatevikg1

src/Messaging/Request/CreateBounceRegexRequest.php

@@ -6,6 +6,7 @@
 
 use PhpList\RestBundle\Common\Request\RequestInterface;
 use Symfony\Component\Validator\Constraints as Assert;
+use Symfony\Component\Validator\Context\ExecutionContextInterface;
 
 class CreateBounceRegexRequest implements RequestInterface
 {
@@ -39,4 +40,24 @@ public function getDto(): array
             'status' => $this->status,
         ];
     }
+
+    #[Assert\Callback('validateRegexPattern')]
+    public function validateRegexPattern(ExecutionContextInterface $context): void
+    {
+        if (!isset($this->regex)) {
+            return;
+        }
+        set_error_handler(static function () {
+            return true;
+        });
+        // phpcs:ignore Generic.PHP.NoSilencedErrors
+        $allGood = @preg_match($this->regex, '');
+        restore_error_handler();
+
+        if ($allGood === false) {
+            $context->buildViolation('Invalid regular expression pattern.')
+                ->atPath('regex')
+                ->addViolation();
+        }
+    }
 }

tests/Unit/Messaging/Request/CreateBounceRegexRequestTest.php

@@ -6,6 +6,8 @@
 
 use PhpList\RestBundle\Messaging\Request\CreateBounceRegexRequest;
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Validator\Context\ExecutionContextInterface;
+use Symfony\Component\Validator\Violation\ConstraintViolationBuilderInterface;
 
 class CreateBounceRegexRequestTest extends TestCase
 {
@@ -43,4 +45,36 @@ public function testGetDtoWithDefaults(): void
         $this->assertNull($dto['comment']);
         $this->assertNull($dto['status']);
     }
+
+    public function testValidateRegexPatternWithValidRegexDoesNotAddViolation(): void
+    {
+        $req = new CreateBounceRegexRequest();
+        $req->regex = '/valid.*/i';
+
+        $context = $this->createMock(ExecutionContextInterface::class);
+        $context->expects($this->never())->method('buildViolation');
+
+        $req->validateRegexPattern($context);
+
+        // if no exception and no violation calls, the test passes
+        $this->assertTrue(true);
+    }
+
+    public function testValidateRegexPatternWithInvalidRegexAddsViolation(): void
+    {
+        $req = new CreateBounceRegexRequest();
+        $req->regex = '/[invalid';
+
+        $builder = $this->createMock(ConstraintViolationBuilderInterface::class);
+        $builder->expects($this->once())->method('atPath')->with('regex')->willReturnSelf();
+        $builder->expects($this->once())->method('addViolation');
+
+        $context = $this->createMock(ExecutionContextInterface::class);
+        $context->expects($this->once())
+            ->method('buildViolation')
+            ->with('Invalid regular expression pattern.')
+            ->willReturn($builder);
+
+        $req->validateRegexPattern($context);
+    }
 }