avoid parse anonymous class for isFinal, isAbstract, isReadonly (#495)

Author: AlessandroMinoccheri

src/Analyzer/FileVisitor.php

@@ -109,11 +109,17 @@ private function handleClassNode(Node $node): void
                 ->addExtends($node->extends->toString(), $node->getLine());
         }
 
-        $this->classDescriptionBuilder->setFinal($node->isFinal());
+        if (!$node->isAnonymous()) {
+            $this->classDescriptionBuilder->setFinal($node->isFinal());
+        }
 
-        $this->classDescriptionBuilder->setReadonly($node->isReadonly());
+        if (!$node->isAnonymous()) {
+            $this->classDescriptionBuilder->setReadonly($node->isReadonly());
+        }
 
-        $this->classDescriptionBuilder->setAbstract($node->isAbstract());
+        if (!$node->isAnonymous()) {
+            $this->classDescriptionBuilder->setAbstract($node->isAbstract());
+        }
     }
 
     private function handleEnumNode(Node $node): void

tests/Unit/Analyzer/FileVisitorTest.php

@@ -12,6 +12,9 @@
 use Arkitect\CLI\TargetPhpVersion;
 use Arkitect\Expression\ForClasses\DependsOnlyOnTheseNamespaces;
 use Arkitect\Expression\ForClasses\Implement;
+use Arkitect\Expression\ForClasses\IsAbstract;
+use Arkitect\Expression\ForClasses\IsFinal;
+use Arkitect\Expression\ForClasses\IsReadonly;
 use Arkitect\Expression\ForClasses\NotContainDocBlockLike;
 use Arkitect\Expression\ForClasses\NotHaveDependencyOutsideNamespace;
 use Arkitect\Rules\ParsingError;
@@ -1506,4 +1509,81 @@ public function __construct(string $firstName, string $lastName) {
 
         self::assertInstanceOf(ClassDescription::class, $cd[0]);
     }
+
+    public function test_is_final_when_there_is_anonymous_final(): void
+    {
+        $code = <<< 'EOF'
+        <?php
+        namespace App\Foo;
+
+        final class User {
+            public function __construct() {
+               $class = new class() extends Bundle {}
+            }
+        }
+        EOF;
+
+        /** @var FileParser $fp */
+        $fp = FileParserFactory::createFileParser(TargetPhpVersion::create('8.4'));
+        $fp->parse($code, 'relativePathName');
+
+        $cd = $fp->getClassDescriptions();
+        $violations = new Violations();
+        $isFinal = new IsFinal();
+        $isFinal->evaluate($cd[0], $violations, 'we want to add this rule for our software');
+
+        self::assertCount(0, $violations);
+    }
+
+    public function test_is_abstract_when_there_is_anonymous_final(): void
+    {
+        $code = <<< 'EOF'
+        <?php
+        namespace App\Foo;
+
+        abstract class User {
+            public function bar() {
+                $class = new class() extends Bundle {}
+            }
+
+            abstract public function foo() {}
+        }
+        EOF;
+
+        /** @var FileParser $fp */
+        $fp = FileParserFactory::createFileParser(TargetPhpVersion::create('8.4'));
+        $fp->parse($code, 'relativePathName');
+
+        $cd = $fp->getClassDescriptions();
+        $violations = new Violations();
+        $isAbstract = new IsAbstract();
+        $isAbstract->evaluate($cd[0], $violations, 'we want to add this rule for our software');
+
+        self::assertCount(0, $violations);
+    }
+
+    public function test_is_readonly_when_there_is_anonymous_final(): void
+    {
+        $code = <<< 'EOF'
+        <?php
+        namespace App\Foo;
+
+         readonly class User {
+            public function __construct() {
+               $class = new class() extends Bundle {}
+            }
+        }
+        EOF;
+
+        /** @var FileParser $fp */
+        $fp = FileParserFactory::createFileParser(TargetPhpVersion::create('8.4'));
+        $fp->parse($code, 'relativePathName');
+
+        $cd = $fp->getClassDescriptions();
+        $violations = new Violations();
+        $isReadOnly = new IsReadonly();
+        $isReadOnly->evaluate($cd[0], $violations, 'we want to add this rule for our software');
+
+        self::assertCount(0, $violations);
+    }
 }