getting dependencies if we call a static constant (#271)

Author: AlessandroMinoccheri

src/Analyzer/FileVisitor.php

@@ -61,6 +61,20 @@ public function enterNode(Node $node): void
             }
         }
 
+        /**
+         * adding static classes as dependencies
+         * $constantValue = StaticClass::constant;.
+         *
+         * @see FileVisitorTest::test_it_should_return_errors_for_const_outside_namespace
+         */
+        if ($node instanceof Node\Expr\ClassConstFetch &&
+            method_exists($node->class, 'toString') &&
+            null !== $this->classDescriptionBuilder
+        ) {
+            $this->classDescriptionBuilder
+                ->addDependency(new ClassDependency($node->class->toString(), $node->getLine()));
+        }
+
         /**
          * adding static function classes as dependencies
          * $static = StaticClass::foo();.

tests/Unit/Analyzer/FileVisitorTest.php

@@ -380,4 +380,33 @@ class Foo {}
             $cd[0]->getAttributes()
         );
     }
+
+    public function test_it_should_return_errors_for_const_outside_namespace(): void
+    {
+        $code = <<< 'EOF'
+<?php
+namespace Root\Cars;
+use AnotherNamespace\CarMake;
+class KiaSportage extends AbstractCar
+{
+    public function __construct()
+    {
+        parent::__construct(CarMake::KIA, 'Sportage');
+    }
+}
+EOF;
+
+        /** @var FileParser $fp */
+        $fp = FileParserFactory::createFileParser(TargetPhpVersion::create('7.4'));
+        $fp->parse($code, 'relativePathName');
+
+        $cd = $fp->getClassDescriptions();
+
+        $violations = new Violations();
+
+        $notHaveDependencyOutsideNamespace = new NotHaveDependencyOutsideNamespace('Root\Cars');
+        $notHaveDependencyOutsideNamespace->evaluate($cd[0], $violations, 'we want to add this rule for our software');
+
+        $this->assertCount(1, $violations);
+    }
 }