Merge pull request #62 from phpcr/catch_exceptions_when_rendering_list_items

Catch exceptions when rendering list items

Author: dantleech

CHANGELOG.md

@@ -13,6 +13,7 @@ alpha-4
 ### Bugs Fixes
 
 - [args] 28 instances of bad InputArgument constructor fixed
+- [node] `node:list` Catch exceptions when rendering property rows (e.g. on invalid references)
 
 alpha-3
 -------

features/phpcr_node_list.feature

@@ -68,3 +68,11 @@ Feature: List properites and chidren of current nodeA
         """
         jcr:uuid
         """
+
+    Scenario: Catch exception on invalid reference
+        Given I execute the "node:list /tests_general_base/numberPropertyNode/jcr:content" command
+        Then the command should not fail
+        And I should see the following:
+        """
+        One or more weak reference targets have not been found
+        """

src/PHPCR/Shell/Console/Command/Phpcr/NodeListCommand.php

@@ -153,15 +153,22 @@ private function renderProperties($currentNode, $table, $spacers)
 
         $i = 0;
         foreach ($properties as $name => $property) {
-            $i++;
-            if (isset($propertyNames[$name])) {
-                unset($propertyNames[$name]);
+            try {
+                $i++;
+                if (isset($propertyNames[$name])) {
+                    unset($propertyNames[$name]);
+                }
+
+                $valueCell = $this->textHelper->truncate($this->formatter->formatValue($property), 55);
+
+            } catch (\Exception $e) {
+                $valueCell = '<error>' . $e->getMessage() . '</error>';
             }
 
             $table->addRow(array(
                 '<property>' . implode('', $spacers). $name . '</property>',
                 '<property-type>' . $this->formatter->getPropertyTypeName($property->getType()) . '</property-type>',
-                $this->textHelper->truncate($this->formatter->formatValue($property), 55),
+                $valueCell
             ));
         }