Merge pull request #59 from wjzijderveld/fix-set-property-value-argument

dantleech · dantleech · commit d992a7dbee27 · 2014-07-02T22:14:06.000+01:00
Fixed 'value' argument definition for 'node:property:set'
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/NodeMixinAddCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/NodeMixinAddCommand.php
@@ -14,7 +14,7 @@ protected function configure()
         $this->setName('node:mixin:add');
         $this->setDescription('Add the named mixin to the node');
         $this->addArgument('path', InputArgument::REQUIRED, 'Path of node');
-        $this->addArgument('mixinName', null, InputArgument::REQUIRED, null, 'The name of the mixin node type to be added');
+        $this->addArgument('mixinName', InputArgument::REQUIRED, 'The name of the mixin node type to be added');
         $this->setHelp(<<<HERE
 Adds the mixin node type named <info>mixinName</info> to this node.
 
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/NodeMixinRemoveCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/NodeMixinRemoveCommand.php
@@ -13,7 +13,7 @@ protected function configure()
     {
         $this->setName('node:mixin:remove');
         $this->setDescription('Remove the named mixin to the current node');
-        $this->addArgument('mixinName', null, InputArgument::REQUIRED, null, 'The name of the mixin node type to be removeed');
+        $this->addArgument('mixinName', InputArgument::REQUIRED, 'The name of the mixin node type to be removeed');
         $this->setHelp(<<<HERE
 Removes the specified mixin node type from this node and removes
 mixinName from this node's jcr:mixinTypes property.
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/NodeMoveCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/NodeMoveCommand.php
@@ -13,8 +13,8 @@ protected function configure()
     {
         $this->setName('node:move');
         $this->setDescription('Move a node in the current session');
-        $this->addArgument('srcPath', null, InputArgument::REQUIRED, 'The root of the subgraph to be moved.');
-        $this->addArgument('destPath', null, InputArgument::REQUIRED, 'The location to which the subgraph is to be moved');
+        $this->addArgument('srcPath', InputArgument::REQUIRED, 'The root of the subgraph to be moved.');
+        $this->addArgument('destPath', InputArgument::REQUIRED, 'The location to which the subgraph is to be moved');
         $this->setHelp(<<<HERE
 Moves the node at <info>srcPath</info> (and its entire subgraph) to the new
 location at <info>destPath</info>.
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/NodeOrderBeforeCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/NodeOrderBeforeCommand.php
@@ -14,8 +14,8 @@ protected function configure()
         $this->setName('node:order-before');
         $this->setDescription('Reorder a child node of the current node');
         $this->addArgument('path', InputArgument::REQUIRED, 'Path of node');
-        $this->addArgument('srcChildRelPath', null, InputArgument::REQUIRED, 'The relative path to the child node to be moved in the ordering');
-        $this->addArgument('destChildRelPath', null, InputArgument::REQUIRED, 'The relative path to the child before which the node srcChildRelPath will be placed');
+        $this->addArgument('srcChildRelPath', InputArgument::REQUIRED, 'The relative path to the child node to be moved in the ordering');
+        $this->addArgument('destChildRelPath', InputArgument::REQUIRED, 'The relative path to the child before which the node srcChildRelPath will be placed');
         $this->setHelp(<<<HERE
 If this node supports child node ordering, this method inserts the child
 node at <info>srcChildRelPath</info> into the child node list at the position
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/NodePropertyRemoveCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/NodePropertyRemoveCommand.php
@@ -14,7 +14,7 @@ protected function configure()
     {
         $this->setName('node:property:remove');
         $this->setDescription('Remove the property at the given absolute path');
-        $this->addArgument('absPath', null, InputArgument::REQUIRED, 'Absolute path to property');
+        $this->addArgument('absPath', InputArgument::REQUIRED, 'Absolute path to property');
         $this->setHelp(<<<HERE
 Remove the property from the current session at the given absolute path
 HERE
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/NodePropertySetCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/NodePropertySetCommand.php
@@ -17,7 +17,7 @@ protected function configure()
         $this->setName('node:property:set');
         $this->setDescription('Rename the node at the current path');
         $this->addArgument('path', InputArgument::REQUIRED, 'Path of property - can include the node name');
-        $this->addArgument('value', null, InputArgument::OPTIONAL, null, 'Value for named property');
+        $this->addArgument('value', InputArgument::OPTIONAL, 'Value for named property');
         $this->addOption('type', null, InputOption::VALUE_REQUIRED, 'Type of named property');
         $this->setHelp(<<<HERE
 Defines a value for a property identified by its name.
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/NodePropertyShowCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/NodePropertyShowCommand.php
@@ -15,7 +15,7 @@ protected function configure()
     {
         $this->setName('node:property:show');
         $this->setDescription('Show the property at the given absolute path');
-        $this->addArgument('absPath', null, InputArgument::REQUIRED, 'Absolute path to property');
+        $this->addArgument('absPath', InputArgument::REQUIRED, 'Absolute path to property');
         $this->setHelp(<<<HERE
 Show the property at the given absolute path
 HERE
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/NodeRenameCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/NodeRenameCommand.php
@@ -14,7 +14,7 @@ protected function configure()
         $this->setName('node:rename');
         $this->setDescription('Rename the node at the current path');
         $this->addArgument('path', InputArgument::REQUIRED, 'Path of node');
-        $this->addArgument('newName', null, InputArgument::REQUIRED, 'The name of the node to create');
+        $this->addArgument('newName', InputArgument::REQUIRED, 'The name of the node to create');
         $this->setHelp(<<<HERE
 Renames this node to the specified <info>newName</info>. The ordering (if any) of
 this node among it siblings remains unchanged.
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/NodeSetPrimaryTypeCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/NodeSetPrimaryTypeCommand.php
@@ -14,7 +14,7 @@ protected function configure()
         $this->setName('node:set-primary-type');
         $this->setDescription('Set the primary type of the current node');
         $this->addArgument('path', InputArgument::REQUIRED, 'Path of node');
-        $this->addArgument('nodeTypeName', null, InputArgument::REQUIRED, null, 'New primary node type name');
+        $this->addArgument('nodeTypeName', InputArgument::REQUIRED, 'New primary node type name');
         $this->setHelp(<<<HERE
 Changes the primary node type of this node to nodeTypeName.
 
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/NodeTypeEditCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/NodeTypeEditCommand.php
@@ -16,7 +16,7 @@ protected function configure()
     {
         $this->setName('node-type:edit');
         $this->setDescription('Edit or create a node type');
-        $this->addArgument('nodeTypeName', null, InputArgument::REQUIRED, 'The name of the node type to edit or create');
+        $this->addArgument('nodeTypeName', InputArgument::REQUIRED, 'The name of the node type to edit or create');
         $this->setHelp(<<<HERE
 Edit the given node type name with the editor defined in the EDITOR environment variable.
 
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/NodeTypeShowCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/NodeTypeShowCommand.php
@@ -15,7 +15,7 @@ protected function configure()
     {
         $this->setName('node-type:show');
         $this->setDescription('Show the CND of a node type');
-        $this->addArgument('nodeTypeName', null, InputArgument::REQUIRED, 'The name of the node type to show');
+        $this->addArgument('nodeTypeName', InputArgument::REQUIRED, 'The name of the node type to show');
         $this->setHelp(<<<HERE
 Show the CND (Compact Node Definition) of a given node type.
 HERE
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/NodeTypeUnregisterCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/NodeTypeUnregisterCommand.php
@@ -12,7 +12,7 @@ protected function configure()
     {
         $this->setName('node-type:unregister');
         $this->setDescription('Unregister a node type UNSUPPORTED / TODO');
-        $this->addArgument('nodeTypeName', null, InputArgument::REQUIRED, 'The name of the node type to unregister');
+        $this->addArgument('nodeTypeName', InputArgument::REQUIRED, 'The name of the node type to unregister');
         $this->setHelp(<<<HERE
 Unregisters the specified node type
 HERE
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/NodeUpdateCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/NodeUpdateCommand.php
@@ -14,7 +14,7 @@ protected function configure()
         $this->setName('node:update');
         $this->setDescription('Updates a node corresponding to the current one in the given workspace');
         $this->addArgument('path', InputArgument::REQUIRED, 'Path of node');
-        $this->addArgument('srcWorkspace', null, InputArgument::REQUIRED, 'The name of the source workspace');
+        $this->addArgument('srcWorkspace', InputArgument::REQUIRED, 'The name of the source workspace');
         $this->setHelp(<<<HERE
 Updates a node corresponding to the current one in the given workspace.
 
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/SessionNamespaceSetCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/SessionNamespaceSetCommand.php
@@ -13,8 +13,8 @@ protected function configure()
     {
         $this->setName('session:namespace:set');
         $this->setDescription('Set a namespace in the current session');
-        $this->addArgument('prefix', null, InputArgument::REQUIRED, 'The namespace prefix to be set as identifier');
-        $this->addArgument('uri', null, InputArgument::REQUIRED, 'The location of the namespace definition (usually a URI');
+        $this->addArgument('prefix', InputArgument::REQUIRED, 'The namespace prefix to be set as identifier');
+        $this->addArgument('uri', InputArgument::REQUIRED, 'The location of the namespace definition (usually a URI');
         $this->setHelp(<<<HERE
 Sets the name of a namespace prefix.
 
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/VersionCheckinCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/VersionCheckinCommand.php
@@ -13,7 +13,7 @@ protected function configure()
     {
         $this->setName('version:checkin');
         $this->setDescription('Checkin (commit) a node version');
-        $this->addArgument('path', null, InputArgument::REQUIRED, 'Absolute path to node');
+        $this->addArgument('path', InputArgument::REQUIRED, 'Absolute path to node');
         $this->setHelp(<<<HERE
 Creates for the versionable node at <info>path</info> a new version with a system
 generated version name and returns that version (which will be the new
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/VersionCheckoutCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/VersionCheckoutCommand.php
@@ -13,7 +13,7 @@ protected function configure()
     {
         $this->setName('version:checkout');
         $this->setDescription('Checkout a node version and enable changes to be made');
-        $this->addArgument('path', null, InputArgument::REQUIRED, 'Absolute path to node');
+        $this->addArgument('path', InputArgument::REQUIRED, 'Absolute path to node');
         $this->setHelp(<<<HERE
 Sets the versionable node at <info>path</info> to checked-out status by setting
 its jcr:isCheckedOut property to true. Under full versioning it also sets
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/VersionCheckpointCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/VersionCheckpointCommand.php
@@ -13,7 +13,7 @@ protected function configure()
     {
         $this->setName('version:checkpoint');
         $this->setDescription('Checkin and then checkout a node');
-        $this->addArgument('path', null, InputArgument::REQUIRED, 'Path to node');
+        $this->addArgument('path', InputArgument::REQUIRED, 'Path to node');
         $this->setHelp(<<<HERE
 Performs a <info>version:checkin</info> followed by a <info>version:checkout</info> on the versionable node at
 <info>path</info>
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/VersionHistoryCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/VersionHistoryCommand.php
@@ -13,7 +13,7 @@ protected function configure()
     {
         $this->setName('version:history');
         $this->setDescription('Show version history of node at given absolute path');
-        $this->addArgument('path', null, InputArgument::REQUIRED, 'Absolute path to node');
+        $this->addArgument('path', InputArgument::REQUIRED, 'Absolute path to node');
         $this->setHelp(<<<HERE
 Lists the version history of the node given at <info>path</info>.
 HERE
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/VersionRemoveCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/VersionRemoveCommand.php
@@ -13,8 +13,8 @@ protected function configure()
     {
         $this->setName('version:remove');
         $this->setDescription('Remove a node version');
-        $this->addArgument('path', null, InputArgument::REQUIRED, 'Path to node');
-        $this->addArgument('versionName', null, InputArgument::REQUIRED, 'Name of version to remove');
+        $this->addArgument('path', InputArgument::REQUIRED, 'Path to node');
+        $this->addArgument('versionName', InputArgument::REQUIRED, 'Name of version to remove');
         $this->setHelp(<<<HERE
 Removes the named version from this version history and automatically
 repairs the version graph.
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/VersionRestoreCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/VersionRestoreCommand.php
@@ -14,8 +14,8 @@ protected function configure()
     {
         $this->setName('version:restore');
         $this->setDescription('Restore a node version');
-        $this->addArgument('path', null, InputArgument::REQUIRED, 'Path to node');
-        $this->addArgument('versionName', null, InputArgument::REQUIRED, 'Name of version to retore');
+        $this->addArgument('path', InputArgument::REQUIRED, 'Path to node');
+        $this->addArgument('versionName', InputArgument::REQUIRED, 'Name of version to retore');
         $this->addOption('remove-existing', null, InputOption::VALUE_NONE, 'Flag that governs what happens in case of identifier collision');
         $this->setHelp(<<<HERE
 Attempt to restore an old version of a node.
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/WorkspaceNamespaceRegisterCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/WorkspaceNamespaceRegisterCommand.php
@@ -13,8 +13,8 @@ protected function configure()
     {
         $this->setName('workspace:namespace:register');
         $this->setDescription('Sets a one-to-one mapping between prefix and uri in the global namespace');
-        $this->addArgument('prefix', null, InputArgument::REQUIRED, 'The namespace prefix to be mapped');
-        $this->addArgument('uri', null, InputArgument::REQUIRED, 'The URI to be mapped');
+        $this->addArgument('prefix', InputArgument::REQUIRED, 'The namespace prefix to be mapped');
+        $this->addArgument('uri', InputArgument::REQUIRED, 'The URI to be mapped');
         $this->setHelp(<<<HERE
 List all namespace prefix to URI  mappings in current session
 HERE
diff --git a/src/PHPCR/Shell/Console/Command/Phpcr/WorkspaceNamespaceUnregisterCommand.php b/src/PHPCR/Shell/Console/Command/Phpcr/WorkspaceNamespaceUnregisterCommand.php
@@ -13,7 +13,7 @@ protected function configure()
     {
         $this->setName('workspace:namespace:unregister');
         $this->setDescription('Unregister a namespace');
-        $this->addArgument('uri', null, InputArgument::REQUIRED, 'The URI to be removed');
+        $this->addArgument('uri', InputArgument::REQUIRED, 'The URI to be removed');
         $this->setHelp(<<<HERE
 Removes the specified namespace URI from namespace registry.
 

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ protected function configure()`
`13`	`13`	`{`
`14`	`14`	`$this->setName('node:mixin:remove');`
`15`	`15`	`$this->setDescription('Remove the named mixin to the current node');`
`16`		`- $this->addArgument('mixinName', null, InputArgument::REQUIRED, null, 'The name of the mixin node type to be removeed');`
	`16`	`+ $this->addArgument('mixinName', InputArgument::REQUIRED, 'The name of the mixin node type to be removeed');`
`17`	`17`	`$this->setHelp(<<<HERE`
`18`	`18`	`Removes the specified mixin node type from this node and removes`
`19`	`19`	`mixinName from this node's jcr:mixinTypes property.`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ protected function configure()`
`14`	`14`	`{`
`15`	`15`	`$this->setName('node:property:remove');`
`16`	`16`	`$this->setDescription('Remove the property at the given absolute path');`
`17`		`- $this->addArgument('absPath', null, InputArgument::REQUIRED, 'Absolute path to property');`
	`17`	`+ $this->addArgument('absPath', InputArgument::REQUIRED, 'Absolute path to property');`
`18`	`18`	`$this->setHelp(<<<HERE`
`19`	`19`	`Remove the property from the current session at the given absolute path`
`20`	`20`	`HERE`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ protected function configure()`
`15`	`15`	`{`
`16`	`16`	`$this->setName('node:property:show');`
`17`	`17`	`$this->setDescription('Show the property at the given absolute path');`
`18`		`- $this->addArgument('absPath', null, InputArgument::REQUIRED, 'Absolute path to property');`
	`18`	`+ $this->addArgument('absPath', InputArgument::REQUIRED, 'Absolute path to property');`
`19`	`19`	`$this->setHelp(<<<HERE`
`20`	`20`	`Show the property at the given absolute path`
`21`	`21`	`HERE`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ protected function configure()`
`16`	`16`	`{`
`17`	`17`	`$this->setName('node-type:edit');`
`18`	`18`	`$this->setDescription('Edit or create a node type');`
`19`		`- $this->addArgument('nodeTypeName', null, InputArgument::REQUIRED, 'The name of the node type to edit or create');`
	`19`	`+ $this->addArgument('nodeTypeName', InputArgument::REQUIRED, 'The name of the node type to edit or create');`
`20`	`20`	`$this->setHelp(<<<HERE`
`21`	`21`	`Edit the given node type name with the editor defined in the EDITOR environment variable.`
`22`	`22`