Hooked properties cannot be both final and private

Author: staabm

src/Node/ClassPropertyNode.php

@@ -86,6 +86,11 @@ public function isPrivate(): bool
 		return (bool) ($this->flags & Modifiers::PRIVATE);
 	}
 
+	public function isFinal(): bool
+	{
+		return (bool) ($this->flags & Modifiers::FINAL);
+	}
+
 	public function isStatic(): bool
 	{
 		return (bool) ($this->flags & Modifiers::STATIC);

src/Rules/Properties/PropertyInClassRule.php

@@ -81,6 +81,32 @@ public function processNode(Node $node, Scope $scope): array
 			];
 		}
 
+		if ($node->isPrivate()) {
+			if ($node->hasHooks()) {
+				if ($node->isFinal()) {
+					return [
+						RuleErrorBuilder::message('Hooked properties cannot be both final and private.')
+							->nonIgnorable()
+							->identifier('property.abstractPrivate')
+							->build(),
+					];
+				}
+
+				foreach ($node->getHooks() as $hook) {
+					if (!$hook->isFinal()) {
+						continue;
+					}
+
+					return [
+						RuleErrorBuilder::message('Hooked properties cannot be both final and private.')
+							->nonIgnorable()
+							->identifier('property.abstractPrivate')
+							->build(),
+					];
+				}
+			}
+		}
+
 		if ($node->isReadOnly()) {
 			if ($node->hasHooks()) {
 				return [

tests/PHPStan/Rules/Properties/PropertyInClassRuleTest.php

@@ -213,4 +213,22 @@ public function testPhp84AndStaticHookedProperties(): void
 		]);
 	}
 
+	public function testPhp84AndPrivateFinalHookedProperties(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4 or later.');
+		}
+
+		$this->analyse([__DIR__ . '/data/private-final-property-hooks.php'], [
+			[
+				'Hooked properties cannot be both final and private.',
+				7,
+			],
+			[
+				'Hooked properties cannot be both final and private.',
+				11,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Properties/data/private-final-property-hooks.php

@@ -0,0 +1,35 @@
+<?php // lint >= 8.4
+
+namespace PrivateFinalHook;
+
+final class User
+{
+	final private string $privatePropGet = 'mailto: example.org' {
+		get => 'private:' . $this->privatePropGet;
+	}
+
+	private string $privateSet = 'mailto: example.org' {
+		final set => 'private:' . $this->privateSet;
+	}
+
+	protected string $protected = 'mailto: example.org' {
+		final get => 'protected:' . $this->protected;
+	}
+
+	public string $public = 'mailto: example.org' {
+		final get => 'public:' . $this->public;
+	}
+
+	private string $email = 'mailto: example.org' {
+		get => 'mailto:' . $this->email;
+	}
+
+	function doFoo(): void
+	{
+		$u = new User;
+		var_dump($u->private);
+		var_dump($u->protected);
+		var_dump($u->public);
+		var_dump($u->email);
+	}
+}