improve error messages

Author: staabm

src/Rules/Properties/PropertiesInInterfaceRule.php

@@ -32,7 +32,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		if (!$this->phpVersion->supportsPropertyHooks()) {
 			return [
-				RuleErrorBuilder::message('Interfaces cannot include properties.')
+				RuleErrorBuilder::message('Interfaces can include properties only on PHP 8.4 and later.')
 					->nonIgnorable()
 					->identifier('property.inInterface')
 					->build(),

src/Rules/Properties/PropertyInClassRule.php

@@ -109,15 +109,15 @@ public function processNode(Node $node, Scope $scope): array
 				}
 
 				return [
-					RuleErrorBuilder::message('Property cannot be both final and private.')
+					RuleErrorBuilder::message('Private property cannot have a final hook.')
 						->nonIgnorable()
-						->identifier('property.finalPrivate')
+						->identifier('property.finalPrivateHook')
 						->build(),
 				];
 			}
 		}
 
-		if ($classReflection->isAbstract() && $node->isAbstract()) {
+		if ($node->isAbstract()) {
 			if ($node->isFinal()) {
 				return [
 					RuleErrorBuilder::message('Property cannot be both abstract and final.')

tests/PHPStan/Rules/Properties/PropertiesInInterfaceRuleTest.php

@@ -29,19 +29,19 @@ public function testPhp83AndPropertiesInInterface(): void
 
 		$this->analyse([__DIR__ . '/data/properties-in-interface.php'], [
 			[
-				'Interfaces cannot include properties.',
+				'Interfaces can include properties only on PHP 8.4 and later.',
 				7,
 			],
 			[
-				'Interfaces cannot include properties.',
+				'Interfaces can include properties only on PHP 8.4 and later.',
 				9,
 			],
 			[
-				'Interfaces cannot include properties.',
+				'Interfaces can include properties only on PHP 8.4 and later.',
 				11,
 			],
 			[
-				'Interfaces cannot include properties.',
+				'Interfaces can include properties only on PHP 8.4 and later.',
 				13,
 			],
 		]);
@@ -58,11 +58,11 @@ public function testPhp83AndPropertyHooksInInterface(): void
 
 		$this->analyse([__DIR__ . '/data/property-hooks-in-interface.php'], [
 			[
-				'Interfaces cannot include properties.',
+				'Interfaces can include properties only on PHP 8.4 and later.',
 				7,
 			],
 			[
-				'Interfaces cannot include properties.',
+				'Interfaces can include properties only on PHP 8.4 and later.',
 				9,
 			],
 		]);

tests/PHPStan/Rules/Properties/PropertyInClassRuleTest.php

@@ -225,7 +225,7 @@ public function testPhp84AndPrivateFinalHookedProperties(): void
 				7,
 			],
 			[
-				'Property cannot be both final and private.',
+				'Private property cannot have a final hook.',
 				11,
 			],
 		]);