add more test cases

Author: SplotyCode

tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php

@@ -704,6 +704,14 @@ public static function dataReportPossiblyNonexistentArrayOffset(): iterable
 				'Offset int might not exist on list<int>.',
 				77
 			],
+			[
+				'Offset int<0, max> might not exist on list<int>.',
+				88
+			],
+			[
+				'Offset int<0, max> might not exist on array<int, int>.',
+				100
+			],
 		]];
 		yield [true, true, [
 			[
@@ -718,6 +726,14 @@ public static function dataReportPossiblyNonexistentArrayOffset(): iterable
 				'Offset int might not exist on list<int>.',
 				77
 			],
+			[
+				'Offset int<0, max> might not exist on list<int>.',
+				88
+			],
+			[
+				'Offset int<0, max> might not exist on array<int, int>.',
+				100
+			],
 		]];
 	}
 

tests/PHPStan/Rules/Arrays/data/report-possibly-nonexistent-array-offset.php

@@ -59,7 +59,7 @@ public function nonEmpty(array $a): void
 
 	/**
 	 * @param list<int> $array
-	 * @param positive-int $index
+	 * @param non-negative-int $index
 	 */
 	public function guard(array $array, int $index) {
 		if ($index < count($array)) {
@@ -72,10 +72,33 @@ public function guard(array $array, int $index) {
 	/**
 	 * @param list<int> $array
 	 */
-	public function guardNotSafe(array $array, int $index) {
+	public function guardNotSafeLowerBound(array $array, int $index) {
 		if ($index < count($array)) {
 			return $array[$index];
 		}
 		return null;
 	}
+
+	/**
+	 * @param list<int> $array
+	 * @param non-negative-int $index
+	 */
+	public function guardNotSafeUpperBound(array $array, int $index) {
+		if ($index <= count($array)) {
+			return $array[$index];
+		}
+		return null;
+	}
+
+
+	/**
+	 * @param array<int, int> $array
+	 * @param non-negative-int $index
+	 */
+	public function guardNotSafeArray(array $array, int $index) {
+		if ($index <= count($array)) {
+			return $array[$index];
+		}
+		return null;
+	}
 }