Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect return type checks with yielding closures #12462

Open
sebkehr opened this issue Jan 22, 2025 · 0 comments · May be fixed by phpstan/phpstan-src#3794
Open

Incorrect return type checks with yielding closures #12462

sebkehr opened this issue Jan 22, 2025 · 0 comments · May be fixed by phpstan/phpstan-src#3794
Labels
Milestone

Comments

@sebkehr
Copy link

sebkehr commented Jan 22, 2025

Bug report

For some reason a yielding closure as well as the generator returned upon invocation may falsely pass return type checks.

Code snippet that reproduces the problem

https://phpstan.org/r/5970e2e2-0aad-4927-8938-3f7d83e73a95

Expected output

Both return statements should trigger an error due the returned values not being integers.

Did PHPStan help you today? Did it make you happy in any way?

Yes :), cf. #12363 (comment).

@sebkehr sebkehr changed the title Falsely passed return type checks wrt. yielding closures Incorrect return type checks with yielding closures Jan 23, 2025
@ondrejmirtes ondrejmirtes added this to the Easy fixes milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants