Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readonly object ArrayAccess assignment detection #8929

Open
netpok opened this issue Feb 21, 2023 · 0 comments · May be fixed by phpstan/phpstan-src#3795
Open

Readonly object ArrayAccess assignment detection #8929

netpok opened this issue Feb 21, 2023 · 0 comments · May be fixed by phpstan/phpstan-src#3795
Labels
bug
Milestone
Easy fixes

Comments

@netpok
Copy link

netpok commented Feb 21, 2023

Bug report

ArrayAccess offsetSet mistakenly detected as assignment of the property itself.

Code snippet that reproduces the problem

https://phpstan.org/r/a97143d1-7447-4a63-8b43-683f17783572

Expected output

Since WeakMap implements ArrayAccess the $this->cache[$key] = $value assignement wont update the object itself but calls a method on it. I think it should not generate the warning.

Did PHPStan help you today? Did it make you happy in any way?

Yes, keep up the good work.
@ondrejmirtes ondrejmirtes added this to the Easy fixes milestone Feb 21, 2023
pilif added a commit to pilif/phpstan-src that referenced this issue Jan 24, 2025
@pilif
Allow write access to offsets of readonly ArrayAccess properties
a51425f 
In case a readonly property is an object which implements ArrayAccess,
offet accesses to said property are turned into method calls on PHP's
side and are allowed even on read-only properties.

this fixes phpstan/phpstan#8929
@pilif pilif linked a pull request Jan 24, 2025 that will close this issue
Open
pilif added a commit to pilif/phpstan-src that referenced this issue Jan 24, 2025
@pilif
Allow write access to offsets of readonly ArrayAccess properties
99380da 
In case a readonly property is an object which implements ArrayAccess,
offet accesses to said property are turned into method calls on PHP's
side and are allowed even on read-only properties.

this fixes phpstan/phpstan#8929
pilif added a commit to pilif/phpstan-src that referenced this issue Jan 24, 2025
@pilif
fix checks for phpstan/phpstan#8929
beaff4e 
of course just checking for ArrayAccess isn't enough - it's only valid
for index assignment operations 🤦
pilif added a commit to pilif/phpstan-src that referenced this issue Jan 28, 2025
@pilif
fix checks for phpstan/phpstan#8929
90de7f8 
of course just checking for ArrayAccess isn't enough - it's only valid
for index assignment operations 🤦
pilif added a commit to pilif/phpstan-src that referenced this issue Jan 28, 2025
@pilif
fix checks for phpstan/phpstan#8929
8b59053 
of course just checking for ArrayAccess isn't enough - it's only valid
for index assignment operations 🤦
pilif added a commit to pilif/phpstan-src that referenced this issue Jan 28, 2025
@pilif
Allow write access to offsets of readonly ArrayAccess properties
a7e289f 
In case a readonly property is an object which implements ArrayAccess,
offet accesses to said property are turned into method calls on PHP's
side and are allowed even on read-only properties.

this fixes phpstan/phpstan#8929
pilif added a commit to pilif/phpstan-src that referenced this issue Jan 28, 2025
@pilif
fix checks for phpstan/phpstan#8929
1e35303 
of course just checking for ArrayAccess isn't enough - it's only valid
for index assignment operations 🤦
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Easy fixes
Development

Successfully merging a pull request may close this issue.

Allow write access to offsets of readonly ArrayAccess properties pilif/phpstan-src
2 participants
@ondrejmirtes @netpok