Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing setupVars.conf breaks padd.sh after PiHole v6.0 #421

Open
albertzsigovits opened this issue Feb 18, 2025 · 17 comments
Open

Missing setupVars.conf breaks padd.sh after PiHole v6.0 #421

albertzsigovits opened this issue Feb 18, 2025 · 17 comments
Labels
Fixed In Next Release

Comments

@albertzsigovits
Copy link

Describe the bug
After upgrading PiHole to v6.0, I wanted to use PADD.sh, just as on previous versions.
The bash script defaults to an error message:
https://github.com/pi-hole/PADD/blob/master/padd.sh#L1507

After the v6.0 upgrade, the setupVars.conf file is gone, and only a .update.bak backup file is left behind. (I don't see this being mentioned in the changelog for v6.0).
Probably need to handle the changes in v6.0 to be suitable for PADD.sh to run properly.

A workaround is to re-create the setupVvars.conf file from the .update.bak file (although not sure if it breaks anything), or just modify the script to point to a different filename.

To Reproduce
Steps to reproduce the behavior:

  1. Upgrade PiHole to v6.0
  2. Launch latest padd.sh

Expected behavior
Execution of padd.sh does not result in an error due to the missing setupVars.conf file
@mwoolweaver
Copy link

you will need to use the development branch

https://github.com/pi-hole/PADD/tree/development

@albertzsigovits
Copy link
Author

Awesome, thanks @mwoolweaver !

@accordxtc
Copy link

Any idea on ETA, my padd currently is asking for a password, not sure what password is needed

@mwoolweaver
Copy link

mwoolweaver commented Feb 19, 2025 •
edited
Loading

in most cases it will be the WebUI password you use when login @ http://pi.hole

see here for more info

https://github.com/pi-hole/PADD/tree/development?tab=readme-ov-file#authentication

@accordxtc
Copy link

Silly question for the password and I just typing

./padd.sh --secret and replace the password with mine

@mwoolweaver
Copy link

mwoolweaver commented Feb 19, 2025 •
edited
Loading

./padd.sh --secret <password-here>

replace this <password-here> with your password

@accordxtc
Copy link

Odd must be something I'm missing, added my password for Pihole and it still wont boot PADD

@mwoolweaver
Copy link

are you running on the Pi-hole directly or another device?

@mwoolweaver
Copy link

and try using the version found here

https://github.com/pi-hole/PADD/blob/2fa/padd.sh

has a fix for passing the password with --secret

@accordxtc
Copy link

This is the version I was using. I am running this directly on its own dedicated Rpi

@mwoolweaver
Copy link

as seen in the readme of the development branch

Pi-hole v6 uses a completely new API with a new authentication mechanism

If you run PADD on the same machine as Pi-hole, it's possible to bypass authentication when your local user is member of the pihole group (specifically, if you can access `/etc/pihole/cli_password). For details see pi-hole/FTL#1999

If this is not the case, PADD will ask you for your password and (if configured) your two factor authentication token. You can also pass those as arguments

@salmundo11
Copy link

Not sure if this is the same bug or a new bug, and:

Updated from Pi-hole v5.x to V6. PADD was not previously installed.

Release version of PADD:

pi@pihole64:~$ ./padd.sh
[✗] Error!
    PADD only works in conjunction with Pi-hole!

Dev branch version of PADD:

pi@pihole64:~$ ./padd.sh
./padd.sh: line 8: syntax error near unexpected token `newline'
./padd.sh: line 8: `<!DOCTYPE html>'

@yubiuser
Copy link
Member

pi@pihole64:~$ ./padd.sh
./padd.sh: line 8: syntax error near unexpected token newline' ./padd.sh: line 8: '

You've downloaded the HTML file, not the raw file.

@mwoolweaver
Copy link

https://raw.githubusercontent.com/pi-hole/PADD/refs/heads/development/padd.sh

@salmundo11
Copy link

thanks!

@Andymc1280
Copy link

you will need to use the development branch

https://github.com/pi-hole/PADD/tree/development

how do you switch to development branch (remind me) on a running install (RPi) ?

@mwoolweaver
Copy link

mwoolweaver commented Feb 19, 2025 •
edited
Loading

switching branches for PADD will require you to download the script again from the development branch

https://raw.githubusercontent.com/pi-hole/PADD/refs/heads/development/padd.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed In Next Release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mwoolweaver @salmundo11 @yubiuser @Andymc1280 @albertzsigovits @accordxtc