Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak disabled color #411

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Tweak disabled color #411

merged 2 commits into from
Feb 12, 2025

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?

Fix #64

DHCP and DNSSEC options are shown in red when disabled, the red color gives the impression of an error state. In some cases, disabled is only representing "not in use" and it could be a desirable state.

How does this PR accomplish the above?

Using blue color:

image

Also replacing the red "bad/error" box, with a new "disabled box" in small sizes:

image

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Using blue color because not every disabled setting means an error.

Signed-off-by: RD WebDesign <[email protected]>
@rdwebdesign rdwebdesign requested review from yubiuser and a team February 12, 2025 02:57
@rdwebdesign
Copy link
Member Author

rdwebdesign commented Feb 12, 2025

I also tried Cyan and Magenta, but I think blue is the best option.

@rdwebdesign rdwebdesign changed the title Tweak/disabled color Tweak disabled color Feb 12, 2025
@yubiuser yubiuser merged commit 9b6b051 into development Feb 12, 2025
4 checks passed
@yubiuser yubiuser deleted the tweak/disabled_color branch February 12, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set DNSSEC indicator color to non-red for local upstream resolver.
2 participants