Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Update or add Asset Metadata by name #814

Open
robertSt7 opened this issue Nov 6, 2023 · 2 comments
Open

[Improvement]: Update or add Asset Metadata by name #814

robertSt7 opened this issue Nov 6, 2023 · 2 comments

Comments

@robertSt7
Copy link
Contributor

Expected behavior

No records will be deleted when executing an update

Actual behavior

Update Asset Metadata delete records which are not in the query

Steps to reproduce

mutation {
  updateAsset
  (
    id : 320,
    input :
    {
      metadata : 
      [
        {
          name:"title",type:"input",data:"title_test_edited_by_n8n"
        }
      ] 
    }
  )
    {
      success
    }
}
@robertSt7 robertSt7 added the Bug label Nov 6, 2023
@dvesh3 dvesh3 added this to the 1.6.5 milestone Nov 7, 2023
@dvesh3
Copy link
Contributor

dvesh3 commented Nov 8, 2023

This is how core API works as it refreshes the records in db. If the requirement is to update or append only the metadata then we should add new property as an improvement.

@robertSt7 robertSt7 added Improvement and removed Bug labels Nov 9, 2023
@robertSt7 robertSt7 changed the title [Bug]: Update Asset Metadata delete records [Improvement]: Update or add Asset Metadata by name Nov 9, 2023
@robertSt7 robertSt7 modified the milestones: 1.6.5, 1.7.0 Nov 9, 2023
@fashxp fashxp modified the milestones: 1.7.0, 1.8.0 Jan 30, 2024
@fashxp fashxp removed this from the 1.8.0 milestone Sep 2, 2024
Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants