Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Ability to Upload Yaml Files #921

Open
cancan101 opened this issue Dec 9, 2024 · 1 comment
Open

[Feature]: Ability to Upload Yaml Files #921

cancan101 opened this issue Dec 9, 2024 · 1 comment

Comments

@cancan101
Copy link
Contributor

Feature description

Currently trying to upload yaml fails. Only JSON look to be accepted:
Image

/**
* @Route("/import", methods={"POST"})
*
*/
public function importConfiguration(Request $request, ImportService $importService): JsonResponse
{
try {
$this->checkPermission(self::CONFIG_NAME);
$json = file_get_contents($_FILES['Filedata']['tmp_name']);
$configuration = $importService->importConfigurationJson($json);

this is despite yaml being the format we store the configs on file system.

Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant