Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: include parent path in error messages when creating #926

Open
dkarlovi opened this issue Jan 2, 2025 · 1 comment
Open

Comments

@dkarlovi
Copy link
Contributor

dkarlovi commented Jan 2, 2025

Improvement description

Currently you'll get an error message like

not allowed to create object <class>

as seen here:

if (!$me->omitPermissionCheck && !WorkspaceHelper::checkPermission($parent, 'create')) {

The error message here could be improved by specifying which parent we're creating in, allowing the user to notice they've passed an invalid parent (this is especially important if they have a level of indirection between them and passing the parent, they don't pass it directly).

something like

not allowed to create object <class> at path <path>

would improve this significantly.

Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant