Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance for round(col_floating, frac) #9860

Open
guo-shaoge opened this issue Feb 11, 2025 · 0 comments
Open

improve performance for round(col_floating, frac) #9860

guo-shaoge opened this issue Feb 11, 2025 · 0 comments
Labels
component/compute type/enhancement The issue or PR belongs to an enhancement.

Comments

@guo-shaoge
Copy link
Contributor

guo-shaoge commented Feb 11, 2025

Enhancement

For now, TiDBFloatingRound use std::pow to compute base, which may hurt performance. Should use pre-computed array, like TiDBDecimalRound and TiDBIntegerRound, check

using Pow = ConstPowOf10<UnsignedOutput, digits>;

@guo-shaoge guo-shaoge added the type/enhancement The issue or PR belongs to an enhancement. label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/compute type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants