Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine Aggregator code #9949

Open
guo-shaoge opened this issue Mar 6, 2025 · 0 comments
Open

refine Aggregator code #9949

guo-shaoge opened this issue Mar 6, 2025 · 0 comments
Assignees
@guo-shaoge
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@guo-shaoge
Copy link
Contributor

Enhancement

For now, Aggregator.cpp is too complicated, it's too long, we should split it into different files, just like ClickHouse.

Split Aggregator.cpp to

  1. Aggregator.cpp: core aggregation logic
  2. AggregationMethod: all methods
  3. AggregatedDataVariants
@guo-shaoge guo-shaoge added the type/enhancement The issue or PR belongs to an enhancement. label Mar 6, 2025
@guo-shaoge guo-shaoge self-assigned this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guo-shaoge guo-shaoge

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@guo-shaoge