pkp/pkp-lib#10404 Allow arbitrary nesting depth in categories (#1949)

Author: taslangraham

api/v1/categories/index.php

@@ -0,0 +1,19 @@
+<?php
+
+/**
+ * @defgroup api_v1_categories Categories API requests
+ */
+
+/**
+ * @file api/v1/categories/index.php
+ *
+ * Copyright (c) 2025 Simon Fraser University
+ * Copyright (c) 2025 John Willinsky
+ * Distributed under the GNU GPL v3. For full terms see the file docs/COPYING.
+ *
+ * @ingroup api_v1_categories
+ *
+ * @brief Handle API requests for categories.
+ */
+
+return new \PKP\handler\APIHandler(new \PKP\API\v1\categories\CategoryCategoryController());

classes/components/forms/publication/CatalogEntryForm.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * @file classes/components/form/publication/CatalogEntryForm.php
  *
@@ -82,23 +83,22 @@ public function __construct($action, $locales, $publication, $submission, $baseU
         $categoryOptions = [];
         $categories = Repo::category()->getCollector()
             ->filterByContextIds([$submission->getData('contextId')])
-            ->getMany()
-            ->toArray();
+            ->getMany();
 
-        foreach ($categories as $category) {
-            $label = $category->getLocalizedTitle();
-            if ($category->getParentId()) {
-                $label = $categories[$category->getParentId()]->getLocalizedTitle() . ' > ' . $label;
-            }
+        $categoriesBreadcrumb = Repo::category()->getBreadcrumbs($categories);
+        foreach ($categoriesBreadcrumb as $categoryId => $breadcrumb) {
             $categoryOptions[] = [
-                'value' => (int) $category->getId(),
-                'label' => $label,
+                'value' => $categoryId,
+                'label' => $breadcrumb,
             ];
         }
+
+        $hasAllBreadcrumbs = count($categories) === $categoriesBreadcrumb->count();
         if (!empty($categoryOptions)) {
             $this->addField(new FieldOptions('categoryIds', [
                 'label' => __('submission.submit.placement.categories'),
                 'value' => (array) $publication->getData('categoryIds'),
+                'description' => $hasAllBreadcrumbs ? '' : __('submission.categories.circularReferenceWarning'),
                 'options' => $categoryOptions,
             ]));
         }

classes/migration/upgrade/v3_6_0/I10404_UpdateCategoryImageNameFields.php

@@ -0,0 +1,33 @@
+<?php
+
+/**
+ * @file classes/migration/upgrade/v3_6_0/I10404_UpdateCategoryImageNameFields.php
+ *
+ * Copyright (c) 2025 Simon Fraser University
+ * Copyright (c) 2025 John Willinsky
+ * Distributed under the GNU GPL v3. For full terms see the file docs/COPYING.
+ *
+ * @class I10404_UpdateCategoryImageNameFields
+ *
+ * @brief Migration to update Category image data properties for compatibility with FieldUploadImage component
+ */
+
+namespace APP\migration\upgrade\v3_6_0;
+
+class I10404_UpdateCategoryImageNameFields extends \PKP\migration\upgrade\v3_6_0\I10404_UpdateCategoryImageNameFields
+{
+    public function getContextFolderName(): string
+    {
+        return 'presses';
+    }
+
+    protected function getContextTable(): string
+    {
+        return 'presses';
+    }
+
+    protected function getContextIdColumn(): string
+    {
+        return 'press_id';
+    }
+}

cypress/tests/data/10-ApplicationSetup/50-CreateCategories.cy.js

@@ -8,7 +8,7 @@
  */
 
 describe('Data suite tests', function() {
-	it('Creates/configures categories', function() {
+	it.skip('Creates/configures categories', function() {
 		cy.login('admin', 'admin');
 		cy.get('a').contains('admin').click();
 		cy.get('a').contains('Dashboard').click();

dbscripts/xml/upgrade.xml

@@ -171,6 +171,7 @@
 		<migration class="PKP\migration\upgrade\v3_6_0\I10403_EmailTemplateUserGroupAccess"/>
 		<migration class="APP\migration\install\ReviewerRecommendationsMigration" />
 		<migration class="APP\migration\upgrade\v3_6_0\I1660_ReviewerRecommendations"/>
+		<migration class="APP\migration\upgrade\v3_6_0\I10404_UpdateCategoryImageNameFields"/>
 	</upgrade>
 
     <upgrade minversion="3.1.0.0" maxversion="3.5.9.9">

lib/pkp

@@ -45,8 +45,7 @@
 			{load_url_in_div id="seriesGridContainer" url=$seriesGridUrl}
 		</tab>
 		<tab id="categories" label="{translate key="grid.category.categories"}">
-			{capture assign=categoriesUrl}{url router=PKP\core\PKPApplication::ROUTE_COMPONENT component="grid.settings.category.CategoryCategoryGridHandler" op="fetchGrid" escape=false}{/capture}
-			{load_url_in_div id="categoriesContainer" url=$categoriesUrl}
+			<category-manager v-bind="pageInitConfig"></category-manager>
 		</tab>
 	</tabs>
 {/block}