-
Notifications
You must be signed in to change notification settings - Fork 461
Clean up specific invitation code mixed into general toolset #11118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
pkp#11118 Proposed fixes for cleanup
@asmecher @withanage, @ipula has prepared the following PRs for this issue:
These PRs complete the separation of generic and invitation-specific code relevant to this issue. @withanage @ipula @Tribunal33 @asmecher |
Merged, sorry on jumping gun on the ui-library part.. I did not realise that is pkp-lib part while going through various PRs.. even though its quite obvious.. Tests are passing for me locally with these changes.. will watch out for that on the GA as well.. |
I create a PR for that here |
The generic
InvitationHandler
class accidentally got some invitation-specific code mixed into it with #10576. The code specific to the user invitation should be moved to its respective handler, leavingInvitationHandler
a generic tool for any kind of invitation.The text was updated successfully, but these errors were encountered: