Skip to content

Clean up specific invitation code mixed into general toolset #11118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asmecher opened this issue Mar 18, 2025 · 3 comments
Open

Clean up specific invitation code mixed into general toolset #11118

asmecher opened this issue Mar 18, 2025 · 3 comments
Assignees
Labels
Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks.
Milestone

Comments

@asmecher
Copy link
Member

The generic InvitationHandler class accidentally got some invitation-specific code mixed into it with #10576. The code specific to the user invitation should be moved to its respective handler, leaving InvitationHandler a generic tool for any kind of invitation.

@asmecher asmecher added this to the 3.5.0-1 milestone Mar 18, 2025
@withanage withanage self-assigned this Mar 21, 2025
@withanage withanage added the Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks. label Apr 2, 2025
defstat added a commit to defstat/pkp-lib that referenced this issue Apr 3, 2025
ipula added a commit to ipula/pkp-lib that referenced this issue Apr 8, 2025
@defstat
Copy link
Contributor

defstat commented Apr 18, 2025

@asmecher @withanage, @ipula has prepared the following PRs for this issue:

These PRs complete the separation of generic and invitation-specific code relevant to this issue.
The respective ui-lib changes were merged yesterday separately.

@withanage @ipula @Tribunal33
There's a separate case in the "Edit User" flow — when a userId is provided that doesn't exist, it currently throws an HTTP 500 error. I believe that could be handled in a separate issue.

@asmecher
I don’t have the necessary permissions to fully merge the above PRs. Would you be able to assist with that?

@jardakotesovec
Copy link
Contributor

Merged, sorry on jumping gun on the ui-library part.. I did not realise that is pkp-lib part while going through various PRs.. even though its quite obvious..

Tests are passing for me locally with these changes.. will watch out for that on the GA as well..

@ipula
Copy link
Contributor

ipula commented Apr 18, 2025

@asmecher @withanage, @ipula has prepared the following PRs for this issue:

* `main`: [refactor invitation page handler #11272](https://github.com/pkp/pkp-lib/pull/11272)

* `stable_3_5_0`: [refactor invitation page handler #11266](https://github.com/pkp/pkp-lib/pull/11266)

These PRs complete the separation of generic and invitation-specific code relevant to this issue. The respective ui-lib changes were merged yesterday separately.

@withanage @ipula @Tribunal33 There's a separate case in the "Edit User" flow — when a userId is provided that doesn't exist, it currently throws an HTTP 500 error. I believe that could be handled in a separate issue.

@asmecher I don’t have the necessary permissions to fully merge the above PRs. Would you be able to assist with that?

I create a PR for that here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks.
Projects
None yet
Development

No branches or pull requests

5 participants