Removed IStore.ForkTxNonces()

Author: greymistcube

src/Libplanet.Store/BaseStore.cs

@@ -164,9 +164,6 @@ public virtual long CountBlocks()
         /// <inheritdoc/>
         public abstract void Dispose();
 
-        /// <inheritdoc/>
-        public abstract void ForkTxNonces(Guid sourceChainId, Guid destinationChainId);
-
         /// <inheritdoc/>
         public abstract void PruneOutdatedChains(bool noopWithoutCanon = false);
 

src/Libplanet.Store/DefaultStore.cs

@@ -600,14 +600,6 @@ public override void IncreaseTxNonce(Guid chainId, Address signer, long delta =
             collection.Upsert(docId, new BsonDocument() { ["v"] = new BsonValue(nextNonce) });
         }
 
-        /// <inheritdoc/>
-        public override void ForkTxNonces(Guid sourceChainId, Guid destinationChainId)
-        {
-            LiteCollection<BsonDocument> srcColl = TxNonceCollection(sourceChainId);
-            LiteCollection<BsonDocument> destColl = TxNonceCollection(destinationChainId);
-            destColl.InsertBulk(srcColl.FindAll());
-        }
-
         /// <inheritdoc/>
         public override void PruneOutdatedChains(bool noopWithoutCanon = false)
         {

src/Libplanet.Store/IStore.cs

@@ -257,17 +257,6 @@ public interface IStore : IDisposable
 
         long CountBlocks();
 
-        /// <summary>
-        /// Forks <see cref="Transaction"/> <see cref="Transaction.Nonce"/>s from
-        /// <paramref name="sourceChainId"/> to
-        /// <paramref name="destinationChainId"/>.
-        /// </summary>
-        /// <param name="sourceChainId">The chain <see cref="BlockChain.Id"/> of
-        /// <see cref="Transaction"/> <see cref="Transaction.Nonce"/>s to fork.</param>
-        /// <param name="destinationChainId">The chain <see cref="BlockChain.Id"/> of destination
-        /// <see cref="Transaction"/> <see cref="Transaction.Nonce"/>s.</param>
-        void ForkTxNonces(Guid sourceChainId, Guid destinationChainId);
-
         /// <summary>
         /// Delete all non-canonical chains.
         /// </summary>

src/Libplanet.Store/MemoryStore.cs

@@ -254,14 +254,6 @@ bool IStore.ContainsTransaction(TxId txId) =>
         long IStore.CountBlocks() =>
             _blocks.Count;
 
-        void IStore.ForkTxNonces(Guid sourceChainId, Guid destinationChainId)
-        {
-            if (_txNonces.TryGetValue(sourceChainId, out ConcurrentDictionary<Address, long>? dict))
-            {
-                _txNonces[destinationChainId] = new ConcurrentDictionary<Address, long>(dict);
-            }
-        }
-
         void IStore.PruneOutdatedChains(bool noopWithoutCanon)
         {
             if (!(_canonicalChainId is { } ccid))

test/Libplanet.RocksDBStore.Tests/RocksDBStoreTest.cs

@@ -324,5 +324,27 @@ public void PruneOutdatedChains()
                 store.IterateIndexes(cid3, 0, null));
             Assert.Equal(3, store.CountIndex(cid3));
         }
+
+        [SkippableFact]
+        public void ForkTxNonces()
+        {
+            var path = Path.Combine(Path.GetTempPath(), $"rocksdb_test_{Guid.NewGuid()}");
+            var store = new RocksDBStore(path);
+            Guid sourceChainId = Guid.NewGuid();
+            Guid destinationChainId = Guid.NewGuid();
+            store.IncreaseTxNonce(sourceChainId, Fx.Address1, 1);
+            store.IncreaseTxNonce(sourceChainId, Fx.Address2, 2);
+            store.IncreaseTxNonce(sourceChainId, Fx.Address3, 3);
+
+            store.ForkTxNonces(sourceChainId, destinationChainId);
+
+            Assert.Equal(1, store.GetTxNonce(destinationChainId, Fx.Address1));
+            Assert.Equal(2, store.GetTxNonce(destinationChainId, Fx.Address2));
+            Assert.Equal(3, store.GetTxNonce(destinationChainId, Fx.Address3));
+
+            store.IncreaseTxNonce(sourceChainId, Fx.Address1, 1);
+            Assert.Equal(2, store.GetTxNonce(sourceChainId, Fx.Address1));
+            Assert.Equal(1, store.GetTxNonce(destinationChainId, Fx.Address1));
+        }
     }
 }

test/Libplanet.Tests/Store/ProxyStore.cs

@@ -151,10 +151,6 @@ public virtual bool ContainsTransaction(TxId txId) =>
         public virtual long CountBlocks() =>
             Store.CountBlocks();
 
-        /// <inheritdoc cref="IStore.ForkTxNonces(Guid, Guid)"/>
-        public virtual void ForkTxNonces(Guid sourceChainId, Guid destinationChainId) =>
-            Store.ForkTxNonces(sourceChainId, destinationChainId);
-
         /// <inheritdoc cref="IStore.PruneOutdatedChains(bool)"/>
         public void PruneOutdatedChains(bool noopWithoutCanon = false) =>
             Store.PruneOutdatedChains(noopWithoutCanon);

test/Libplanet.Tests/Store/StoreTest.cs

@@ -901,27 +901,6 @@ public void ManipulateCommittedEvidence()
             }
         }
 
-        [SkippableFact]
-        public void ForkTxNonces()
-        {
-            IStore store = Fx.Store;
-            Guid sourceChainId = Guid.NewGuid();
-            Guid destinationChainId = Guid.NewGuid();
-            store.IncreaseTxNonce(sourceChainId, Fx.Address1, 1);
-            store.IncreaseTxNonce(sourceChainId, Fx.Address2, 2);
-            store.IncreaseTxNonce(sourceChainId, Fx.Address3, 3);
-
-            store.ForkTxNonces(sourceChainId, destinationChainId);
-
-            Assert.Equal(1, store.GetTxNonce(destinationChainId, Fx.Address1));
-            Assert.Equal(2, store.GetTxNonce(destinationChainId, Fx.Address2));
-            Assert.Equal(3, store.GetTxNonce(destinationChainId, Fx.Address3));
-
-            store.IncreaseTxNonce(sourceChainId, Fx.Address1, 1);
-            Assert.Equal(2, store.GetTxNonce(sourceChainId, Fx.Address1));
-            Assert.Equal(1, store.GetTxNonce(destinationChainId, Fx.Address1));
-        }
-
         [SkippableFact]
         public void IdempotentDispose()
         {

test/Libplanet.Tests/Store/StoreTracker.cs

@@ -174,12 +174,6 @@ public void IncreaseTxNonce(Guid chainId, Address address, long delta = 1)
             _store.IncreaseTxNonce(chainId, address, delta);
         }
 
-        public void ForkTxNonces(Guid sourceChainId, Guid destinationChainId)
-        {
-            Log(nameof(ForkTxNonces), sourceChainId, destinationChainId);
-            _store.ForkTxNonces(sourceChainId, destinationChainId);
-        }
-
         public void PruneOutdatedChains(bool noopWithoutCanon = false)
         {
             Log(nameof(PruneOutdatedChains));