fix golint issues

Author: platinummonkey

doc.go

@@ -1,2 +1,2 @@
-// Package go_concurrency_limits provides primitives for concurrency control in complex systems.
-package go_concurrency_limits
+// Package provides primitives for concurrency control in complex systems.
+package main

metric_registry/doc.go

@@ -10,7 +10,8 @@ import (
 )
 
 func ExampleFixedPool() {
-	var JobKey = "job_id"
+	type JobKey string
+	var JobKeyID = JobKey("job_id")
 
 	l := 1000 // limit to 1000 concurrent requests.
 	// create a new pool
@@ -35,7 +36,7 @@ func ExampleFixedPool() {
 	for i := 0; i <= l*3; i++ {
 		go func(c int) {
 			defer wg.Done()
-			ctx := context.WithValue(context.Background(), JobKey, c)
+			ctx := context.WithValue(context.Background(), JobKeyID, c)
 			// this will block until timeout or token was acquired.
 			listener, ok := pool.Acquire(ctx)
 			if !ok {

patterns/pool/example_fixed_pool_test.go

@@ -12,7 +12,8 @@ import (
 )
 
 func ExamplePool() {
-	var JobKey = "job_id"
+	type JobKey string
+	var JobKeyID = JobKey("job_id")
 
 	l := 1000 // limit to adjustable 1000 concurrent requests.
 	delegateLimit := limit.NewDefaultAIMLimit(
@@ -54,7 +55,7 @@ func ExamplePool() {
 	for i := 0; i <= l*3; i++ {
 		go func(c int) {
 			defer wg.Done()
-			ctx := context.WithValue(context.Background(), JobKey, c)
+			ctx := context.WithValue(context.Background(), JobKeyID, c)
 			// this will block until timeout or token was acquired.
 			listener, ok := pool.Acquire(ctx)
 			if !ok {

patterns/pool/example_generic_pool_test.go

@@ -10,7 +10,8 @@ import (
 )
 
 func ExampleLIFOFixedPool() {
-	var JobKey = "job_id"
+	type JobKey string
+	var JobKeyID = JobKey("job_id")
 
 	l := 1000 // limit to 1000 concurrent requests.
 	// create a new pool
@@ -36,7 +37,7 @@ func ExampleLIFOFixedPool() {
 	for i := 0; i <= l*3; i++ {
 		go func(c int) {
 			defer wg.Done()
-			ctx := context.WithValue(context.Background(), JobKey, c)
+			ctx := context.WithValue(context.Background(), JobKeyID, c)
 			// this will block until timeout or token was acquired.
 			listener, ok := pool.Acquire(ctx)
 			if !ok {

patterns/pool/example_lifo_fixed_pool_test.go

@@ -33,7 +33,7 @@ func TestFixedPool(t *testing.T) {
 		wg.Add(1)
 		go func(c int) {
 			defer wg.Done()
-			l, _ := p.Acquire(context.WithValue(context.Background(), "id", fmt.Sprint(c)))
+			l, _ := p.Acquire(context.WithValue(context.Background(), testKeyID, fmt.Sprint(c)))
 			log.Printf("acquired now, sleeping - %d\n", c)
 			time.Sleep(time.Millisecond * 100)
 			l.OnSuccess()

patterns/pool/fixed_pool_test.go

@@ -43,7 +43,7 @@ func TestGenericPool(t *testing.T) {
 		wg.Add(1)
 		go func(c int) {
 			defer wg.Done()
-			l, _ := p.Acquire(context.WithValue(context.Background(), "id", fmt.Sprint(c)))
+			l, _ := p.Acquire(context.WithValue(context.Background(), testKeyID, fmt.Sprint(c)))
 			log.Printf("acquired now, sleeping - %d\n", c)
 			time.Sleep(time.Millisecond * 100)
 			l.OnSuccess()

patterns/pool/generic_pool_test.go

@@ -11,6 +11,10 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
+type testKey string
+
+const testKeyID = testKey("id")
+
 func TestLIFOFixedPool(t *testing.T) {
 	asrt := assert.New(t)
 	p, err := NewLIFOFixedPool(
@@ -34,7 +38,7 @@ func TestLIFOFixedPool(t *testing.T) {
 		wg.Add(1)
 		go func(c int) {
 			defer wg.Done()
-			l, _ := p.Acquire(context.WithValue(context.Background(), "id", fmt.Sprint(c)))
+			l, _ := p.Acquire(context.WithValue(context.Background(), testKeyID, fmt.Sprint(c)))
 			log.Printf("acquired now, sleeping - %d\n", c)
 			time.Sleep(time.Millisecond * 100)
 			l.OnSuccess()

patterns/pool/lifo_fixed_pool_test.go

@@ -48,14 +48,14 @@ func (s *PreciseStrategy) TryAcquire(ctx context.Context) (token core.StrategyTo
 		s.metricListener.AddSample(float64(s.inFlight))
 		return core.NewNotAcquiredStrategyToken(int(s.inFlight)), false
 	}
-	s.inFlight += 1
+	s.inFlight++
 	s.metricListener.AddSample(float64(s.inFlight))
 	return core.NewAcquiredStrategyToken(int(s.inFlight), s.releaseHandler), true
 }
 
 func (s *PreciseStrategy) releaseHandler() {
 	s.mu.Lock()
-	s.inFlight -= 1
+	s.inFlight--
 	s.mu.Unlock()
 }