Merge pull request #13 from systay/dropped-samples

Do not forget dropped samples

Author: platinummonkey

measurements/immutable_sample_window.go

@@ -62,7 +62,7 @@ func (s *ImmutableSampleWindow) AddSample(startTime int64, rtt int64, maxInFligh
 	if startTime < 0 {
 		startTime = time.Now().UnixNano()
 	}
-	return NewImmutableSampleWindow(startTime, minRTT, s.sum+rtt, maxInFlight, s.sampleCount+1, false)
+	return NewImmutableSampleWindow(startTime, minRTT, s.sum+rtt, maxInFlight, s.sampleCount+1, s.didDrop)
 }
 
 // AddDroppedSample will create a new immutable sample that was dropped.

measurements/immutable_sample_window_test.go

@@ -22,6 +22,12 @@ func TestImmutableSampleWindow(t *testing.T) {
 		"ImmutableSampleWindow{minRTT=10, averageRTT=10, maxInFlight=5, sampleCount=1, didDrop=false}",
 		w2.String(),
 	)
+
+	// Adding a dropped sample should mark the window as having contained dropped tokens
 	w3 := w2.AddDroppedSample(-10, 500)
 	asrt.True(w3.DidDrop())
+
+	// Adding a successful sample should not void the dropped marker on the window
+	w4 := w3.AddSample(10, 10, 5)
+	asrt.True(w4.DidDrop())
 }