Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: .scrollable height should be set dynamically #205

Closed
SgtPooki opened this issue Nov 29, 2022 · 2 comments
Closed

feat: .scrollable height should be set dynamically #205

SgtPooki opened this issue Nov 29, 2022 · 2 comments
Assignees
@whizzzkid
Labels
bug Something isn't working effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete MVP P1 status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs

Comments

@SgtPooki
Copy link
Contributor

SgtPooki commented Nov 29, 2022 •
edited
Loading

see https://github.com/pln-planning-tools/StarMaps/pull/199/files#r1034154690

essentially, we're setting padding for the scrollable roadmap grid, so that only the roadmap scrolls, and the rest of the content doesn't. We need to do this in a more exact way.
This was referenced Nov 29, 2022
Merged
Closed
@SgtPooki SgtPooki added enhancement New feature or request status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete P2 bug Something isn't working MVP P1 and removed enhancement New feature or request P2 labels Nov 29, 2022
@SgtPooki SgtPooki added this to Starmap Nov 29, 2022
@SgtPooki SgtPooki moved this to Todo in Starmap Nov 29, 2022
@whizzzkid whizzzkid self-assigned this Nov 29, 2022
@whizzzkid whizzzkid mentioned this issue Nov 29, 2022
Merged
@juliaxbow
Copy link
Collaborator

+1. Bottom margin of the roadmap is too large and since we don't really have a visually defined roadmap area, it is possible that someone scrolls outside of the roadmap area and misses roadmap content

Fixed.Scroll.Bug.mov

@whizzzkid whizzzkid moved this from Todo to Peer Review in Starmap Nov 30, 2022
@whizzzkid
Copy link
Collaborator

No longer needed as this was fixed in #211

Repository owner moved this from Peer Review to Done in Starmap Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whizzzkid whizzzkid

Labels
bug Something isn't working effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete MVP P1 status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs
Projects
Starmap
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SgtPooki @whizzzkid @juliaxbow