Quick and dirty fix proposal for tidyverse/ggplot2#5343

plotly · Oct 6, 2023 · 13b8fec · 13b8fec
1 parent 922bea4
commit 13b8fec
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/R/ggplotly.R b/R/ggplotly.R
@@ -725,11 +725,13 @@ gg2list <- function(p, width = NULL, height = NULL,
           call. = FALSE
         )
       }
-      # determine axis types (note: scale_name may go away someday)
+      # determine axis types (note: scale_name went away in ggplot2 v3.4.3)
       # https://github.com/hadley/ggplot2/issues/1312
-      isDate <- isTRUE(sc$scale_name %in% c("date", "datetime"))
+      isDate <- isTRUE(sc$scale_name %in% c("date", "datetime")) || 
+        inherits(sc, c("ScaleContinuousDatetime", "ScaleContinuousDate"))
       isDateType <- isDynamic && isDate
-      isDiscrete <- identical(sc$scale_name, "position_d")
+      isDiscrete <- identical(sc$scale_name, "position_d") ||
+        inherits(sc, "ScaleDiscretePosition")
       isDiscreteType <- isDynamic && isDiscrete
 
       # In 3.2.x .major disappeared in favor of break_positions()