refactor: get tests/**/*.py to pass ruff check .

Author: gvwilson

tests/percy/plotly-express.py

@@ -9,8 +9,7 @@
 # this directory
 dir_name = os.path.join("tests", "percy")
 
-# #### Scatter and Line plots
-
+# Scatter and Line plots
 
 iris = px.data.iris()
 fig = px.scatter(iris, x="sepal_width", y="sepal_length")
@@ -196,8 +195,7 @@
 fig = px.area(gapminder, x="year", y="pop", color="continent", line_group="country")
 fig.write_html(os.path.join(dir_name, "area.html"))
 
-# #### Visualize Distributions
-
+# Visualize Distributions
 
 iris = px.data.iris()
 fig = px.density_contour(iris, x="sepal_width", y="sepal_length")
@@ -286,8 +284,7 @@
 )
 fig.write_html(os.path.join(dir_name, "violin.html"))
 
-# #### Ternary Coordinates
-
+# Ternary Coordinates
 
 election = px.data.election()
 fig = px.scatter_ternary(
@@ -318,8 +315,7 @@
 fig = px.imshow(img_rgb)
 fig.write_html(os.path.join(dir_name, "imshow.html"))
 
-# #### 3D Coordinates
-
+# 3D Coordinates
 
 election = px.data.election()
 fig = px.scatter_3d(
@@ -342,8 +338,7 @@
 )
 fig.write_html(os.path.join(dir_name, "line_3d.html"))
 
-# #### Polar Coordinates
-
+# Polar Coordinates
 
 wind = px.data.wind()
 fig = px.scatter_polar(
@@ -380,8 +375,7 @@
 )
 fig.write_html(os.path.join(dir_name, "bar_polar.html"))
 
-# #### Maps
-
+# Maps
 
 carshare = px.data.carshare()
 fig = px.scatter_map(

tests/test_core/test_colors/test_colors.py

@@ -1,6 +1,5 @@
 from unittest import TestCase
 
-import plotly.tools as tls
 from plotly.exceptions import PlotlyError
 import plotly.colors as colors
 

tests/test_core/test_errors/test_dict_path_errors.py

@@ -1,5 +1,4 @@
 import plotly.graph_objects as go
-from _plotly_utils.exceptions import PlotlyKeyError
 import pytest
 import sys
 
@@ -23,7 +22,7 @@ def test_raises_on_bad_index(some_fig):
     # Check indexing errors can be detected when path used as key to go.Figure
     raised = False
     try:
-        x0 = some_fig["layout.shapes[2].x0"]
+        some_fig["layout.shapes[2].x0"]
     except KeyError as e:
         raised = True
         assert (
@@ -43,7 +42,7 @@ def test_raises_on_bad_dot_property(some_fig):
     # go.Figure
     raised = False
     try:
-        x2000 = some_fig["layout.shapes[1].x2000"]
+        some_fig["layout.shapes[1].x2000"]
     except KeyError as e:
         raised = True
         assert (
@@ -62,7 +61,7 @@ def test_raises_on_bad_ancestor_dot_property(some_fig):
     # Check . property lookup errors but not on the last part of the path
     raised = False
     try:
-        x2000 = some_fig["layout.shapa[1].x2000"]
+        some_fig["layout.shapa[1].x2000"]
     except KeyError as e:
         raised = True
         assert (
@@ -181,7 +180,7 @@ def test_raises_on_bad_indexed_underscore_property(some_fig):
     # BaseFigure and throws the error for the last good property found in
     # the path
     try:
-        fig2 = go.Figure(layout=dict(title=dict(txt="two")))
+        go.Figure(layout=dict(title=dict(txt="two")))
     except ValueError as e_correct:
         raised = True
         e_correct_substr = error_substr(
@@ -195,7 +194,7 @@ def test_raises_on_bad_indexed_underscore_property(some_fig):
 
     raised = False
     try:
-        fig2 = go.Figure(layout_title_txt="two")
+        go.Figure(layout_title_txt="two")
     except TypeError as e:
         raised = True
         # when the Figure constructor sees the same ValueError above, a
@@ -421,14 +420,14 @@ def test_subscript_error_exception_types(some_fig):
     with pytest.raises(ValueError):
         some_fig.update_layout(width_yo=100)
     with pytest.raises(KeyError):
-        yo = some_fig["layout_width_yo"]
+        some_fig["layout_width_yo"]
 
     some_fig.update_layout(width=100)
     # when width is specified
     with pytest.raises(ValueError):
         some_fig.update_layout(width_yo=100)
     with pytest.raises(KeyError):
-        yo = some_fig["layout_width_yo"]
+        some_fig["layout_width_yo"]
 
 
 def form_error_string(call, exception, subs):

tests/test_core/test_figure_messages/test_add_traces.py

@@ -1,13 +1,9 @@
-import sys
 from unittest import TestCase
 
 import plotly.graph_objs as go
 from plotly.subplots import make_subplots
 
-if sys.version_info >= (3, 3):
-    from unittest.mock import MagicMock
-else:
-    from mock import MagicMock
+from unittest.mock import MagicMock
 
 
 class TestAddTracesMessage(TestCase):
@@ -56,8 +52,6 @@ def test_add_traces(self):
         self.assertEqual(self.figure.data[-1].line.color, "cyan")
 
         # Check message
-        new_uid1 = self.figure.data[-2].uid
-        new_uid2 = self.figure.data[-1].uid
         self.figure._send_addTraces_msg.assert_called_once_with(
             [
                 {"type": "sankey", "arrangement": "snap"},

tests/test_core/test_figure_messages/test_batch_animate.py

@@ -1,12 +1,8 @@
-import sys
 from unittest import TestCase
 
 import plotly.graph_objs as go
 
-if sys.version_info >= (3, 3):
-    from unittest.mock import MagicMock
-else:
-    from mock import MagicMock
+from unittest.mock import MagicMock
 
 
 class TestBatchAnimateMessage(TestCase):

tests/test_core/test_figure_messages/test_move_delete_traces.py

@@ -1,13 +1,9 @@
-import sys
 from unittest import TestCase
 import pytest
 
 import plotly.graph_objs as go
 
-if sys.version_info >= (3, 3):
-    from unittest.mock import MagicMock
-else:
-    from mock import MagicMock
+from unittest.mock import MagicMock
 
 
 class TestMoveDeleteTracesMessages(TestCase):

tests/test_core/test_figure_messages/test_on_change.py

@@ -1,13 +1,9 @@
-import sys
 from unittest import TestCase
 import pytest
 
 import plotly.graph_objs as go
 
-if sys.version_info >= (3, 3):
-    from unittest.mock import MagicMock
-else:
-    from mock import MagicMock
+from unittest.mock import MagicMock
 
 
 class TestOnChangeCallbacks(TestCase):
@@ -35,12 +31,12 @@ def test_raise_on_frame_hierarchy(self):
         with pytest.raises(ValueError):
             self.figure.frames[0].layout.xaxis.on_change(fn, "range")
 
-    def test_validate_property_path_nested(self):
+    def test_validate_property_path_nested_1(self):
         fn = MagicMock()
         with pytest.raises(ValueError):
             self.figure.layout.xaxis.on_change(fn, "bogus")
 
-    def test_validate_property_path_nested(self):
+    def test_validate_property_path_nested_2(self):
         fn = MagicMock()
         with pytest.raises(ValueError):
             self.figure.layout.on_change(fn, "xaxis.title_font.bogus")

tests/test_core/test_figure_messages/test_plotly_relayout.py

@@ -1,12 +1,8 @@
-import sys
 from unittest import TestCase
 
 import plotly.graph_objs as go
 
-if sys.version_info >= (3, 3):
-    from unittest.mock import MagicMock
-else:
-    from mock import MagicMock
+from unittest.mock import MagicMock
 
 
 class TestRelayoutMessage(TestCase):

tests/test_core/test_figure_messages/test_plotly_restyle.py

@@ -1,12 +1,8 @@
-import sys
 from unittest import TestCase
 
 import plotly.graph_objs as go
 
-if sys.version_info >= (3, 3):
-    from unittest.mock import MagicMock
-else:
-    from mock import MagicMock
+from unittest.mock import MagicMock
 
 
 class TestRestyleMessage(TestCase):

tests/test_core/test_figure_messages/test_plotly_update.py

@@ -1,13 +1,9 @@
-import sys
 from unittest import TestCase
 
 import plotly.graph_objs as go
 from plotly.basedatatypes import Undefined
 
-if sys.version_info >= (3, 3):
-    from unittest.mock import MagicMock
-else:
-    from mock import MagicMock
+from unittest.mock import MagicMock
 
 
 class TestBatchUpdateMessage(TestCase):