feat(AbstractType): show icon along name in tab

Author: btry

src/AbstractType.php

@@ -42,6 +42,12 @@ abstract class AbstractType extends CommonDBChild
 {
     public static $rightname = 'dropdown';
 
+
+    public static function getIcon(): string
+    {
+        return 'fa-solid fa-solar-panel';
+    }
+
     /**
      * @todo fix type name
      */
@@ -55,6 +61,7 @@ public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
         $tabName = '';
         if (!$withtemplate) {
             if ($item->getType() == static::$itemtype) {
+                return self::createTabEntry(__('Carbon', 'carbon'), 0);
                 $tabName = __('Carbon', 'carbon');
             }
         }

tests/units/ComputerTypeTest.php

@@ -52,7 +52,8 @@ public function testGetTabNameForItem()
         $glpi_computer_type = $this->createItem(GlpiComputerType::class);
         $instance = new ComputerType();
         $result = $instance->getTabNameForItem($glpi_computer_type);
-        $this->assertEquals('Carbon', $result);
+        $crawler = new Crawler($result);
+        $this->assertEquals('Carbon', $crawler->text());
 
         $result = $instance->getTabNameForItem($glpi_computer_type, 1);
         $this->assertEquals('', $result);

tests/units/MonitorTypeTest.php

@@ -54,7 +54,8 @@ public function testGetTabNameForItem()
         $glpi_monitor_type = $this->createItem(GlpiMonitorType::class);
         $instance = new MonitorType();
         $result = $instance->getTabNameForItem($glpi_monitor_type);
-        $this->assertEquals('Carbon', $result);
+        $crawler = new Crawler($result);
+        $this->assertEquals('Carbon', $crawler->text());
 
         $result = $instance->getTabNameForItem($glpi_monitor_type, 1);
         $this->assertEquals('', $result);

tests/units/NetworkEquipmentTypeTest.php

@@ -55,7 +55,8 @@ public function testGetTabNameForItem()
         $glpi_networkequipment_type = $this->createItem(GlpiNetworkEquipmentType::class);
         $instance = new NetworkEquipmentType();
         $result = $instance->getTabNameForItem($glpi_networkequipment_type);
-        $this->assertEquals('Carbon', $result);
+        $crawler = new Crawler($result);
+        $this->assertEquals('Carbon', $crawler->text());
 
         $result = $instance->getTabNameForItem($glpi_networkequipment_type, 1);
         $this->assertEquals('', $result);