Fix team resource description resync (#84)

Author: dvirsegev

internal/cli/models.go

@@ -266,7 +266,7 @@ type (
 		CreatedAt   *time.Time `json:"createdAt,omitempty"`
 		UpdatedAt   *time.Time `json:"updatedAt,omitempty"`
 		Name        string     `json:"name,omitempty"`
-		Description string     `json:"description,omitempty"`
+		Description *string    `json:"description,omitempty"`
 		Users       []string   `json:"users,omitempty"`
 		Provider    string     `json:"provider,omitempty"`
 	}
@@ -290,7 +290,7 @@ type TeamPortBody struct {
 	CreatedAt   *time.Time     `json:"createdAt,omitempty"`
 	UpdatedAt   *time.Time     `json:"updatedAt,omitempty"`
 	Name        string         `json:"name,omitempty"`
-	Description string         `json:"description,omitempty"`
+	Description *string        `json:"description,omitempty"`
 	Users       []TeamUserBody `json:"users,omitempty"`
 	Provider    string         `json:"provider,omitempty"`
 }

internal/cli/team.go

@@ -70,7 +70,7 @@ func (c *PortClient) UpdateTeam(ctx context.Context, teamName string, team *Team
 		SetBody(team).
 		SetContext(ctx).
 		SetPathParam("name", teamName).
-		Patch(url)
+		Put(url)
 
 	if err != nil {
 		return nil, err

port/team/refreshTeamState.go

@@ -13,7 +13,7 @@ func refreshTeamState(ctx context.Context, state *TeamModel, t *cli.Team) error
 	state.UpdatedAt = types.StringValue(t.UpdatedAt.String())
 	state.ID = types.StringValue(t.Name)
 	state.Name = types.StringValue(t.Name)
-	state.Description = flex.GoStringToFramework(&t.Description)
+	state.Description = flex.GoStringToFramework(t.Description)
 	state.ProviderName = flex.GoStringToFramework(&t.Provider)
 
 	if len(t.Users) != 0 {

port/team/resource_test.go

@@ -102,3 +102,40 @@ func TestAccPortTeamImport(t *testing.T) {
 		},
 	})
 }
+
+func TestAccPortTeamEmptyDescription(t *testing.T) {
+	var testAccTeamConfigCreate = `
+	resource "port_team" "team" {
+		name = "Tf-Test"
+		description = "abc"
+		users = []
+	}`
+
+	var testAccTeamConfigUpdate = `
+	resource "port_team" "team" {
+		name = "Tf-Test"
+		users = []
+	}`
+	resource.Test(t, resource.TestCase{
+		PreCheck:                 func() { acctest.TestAccPreCheck(t) },
+		ProtoV6ProviderFactories: acctest.TestAccProtoV6ProviderFactories,
+		Steps: []resource.TestStep{
+			{
+				Config: acctest.ProviderConfig + testAccTeamConfigCreate,
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("port_team.team", "name", "Tf-Test"),
+					resource.TestCheckResourceAttr("port_team.team", "description", "abc"),
+					resource.TestCheckResourceAttr("port_team.team", "users.#", "0"),
+				),
+			},
+			{
+				Config: acctest.ProviderConfig + testAccTeamConfigUpdate,
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("port_team.team", "name", "Tf-Test"),
+					resource.TestCheckNoResourceAttr("port_team.team", "description"),
+					resource.TestCheckResourceAttr("port_team.team", "users.#", "0"),
+				),
+			},
+		},
+	})
+}

port/team/teamResourceToPortBody.go

@@ -8,9 +8,14 @@ import (
 
 func TeamResourceToPortBody(ctx context.Context, state *TeamModel) (*cli.Team, error) {
 	tp := &cli.Team{
-		Name:        state.Name.ValueString(),
-		Description: state.Description.ValueString(),
+		Name: state.Name.ValueString(),
 	}
+
+	if !state.Description.IsNull() {
+		description := state.Description.ValueString()
+		tp.Description = &description
+	}
+
 	if state.Users != nil {
 		tp.Users = make([]string, len(state.Users))
 		for i, t := range state.Users {