Reenable dead code analysis in lsp/ (#355)

It's too useful to live without!

Author: DavisVaughan

crates/lsp/src/encoding.rs

@@ -1,11 +1,7 @@
-// TODO: Remove this
-#![allow(dead_code)]
-
 pub use tower_lsp::start_lsp;
 
 pub mod capabilities;
 pub mod documents;
-pub mod encoding;
 pub mod file_patterns;
 pub mod from_proto;
 pub mod handlers;

crates/lsp/src/lib.rs

@@ -5,7 +5,6 @@
 //
 //
 
-use std::collections::HashMap;
 use std::future;
 use std::pin::Pin;
 
@@ -57,16 +56,19 @@ type TaskList<T> = futures::stream::FuturesUnordered<Pin<Box<dyn AnyhowJoinHandl
 #[derive(Debug)]
 pub(crate) enum Event {
     Lsp(LspMessage),
+    #[allow(dead_code)]
     Kernel(KernelNotification),
 }
 
 #[derive(Debug)]
 pub(crate) enum KernelNotification {
+    #[allow(dead_code)]
     DidChangeConsoleInputs(ConsoleInputs),
 }
 
 #[derive(Debug)]
 pub(crate) enum AuxiliaryEvent {
+    #[allow(dead_code)]
     PublishDiagnostics(Url, Vec<Diagnostic>, Option<i32>),
     SpawnedTask(JoinHandle<anyhow::Result<Option<AuxiliaryEvent>>>),
 }
@@ -161,9 +163,6 @@ pub(crate) struct LspState {
     /// translate UTF-16 positions sent by the client to UTF-8 ones.
     pub(crate) position_encoding: PositionEncoding,
 
-    /// The set of tree-sitter document parsers managed by the `GlobalState`.
-    pub(crate) parsers: HashMap<Url, tree_sitter::Parser>,
-
     /// List of client capabilities that we care about
     pub(crate) capabilities: AirClientCapabilities,
 
@@ -181,7 +180,6 @@ impl LspState {
             workspace_settings_resolver: Default::default(),
             // All servers and clients have to support UTF-16 so that's the default
             position_encoding: PositionEncoding::Wide(WideEncoding::Utf16),
-            parsers: Default::default(),
             capabilities: Default::default(),
             log_state: Default::default(),
             settings: Default::default(),

crates/lsp/src/main_loop.rs

@@ -29,26 +29,6 @@ pub(crate) fn text_edit(
     Ok(lsp_types::TextEdit { range, new_text })
 }
 
-pub(crate) fn completion_text_edit(
-    line_index: &LineIndex,
-    insert_replace_support: Option<lsp_types::Position>,
-    indel: Indel,
-) -> anyhow::Result<lsp_types::CompletionTextEdit> {
-    let text_edit = text_edit(line_index, indel)?;
-    Ok(match insert_replace_support {
-        Some(cursor_pos) => lsp_types::InsertReplaceEdit {
-            new_text: text_edit.new_text,
-            insert: lsp_types::Range {
-                start: text_edit.range.start,
-                end: cursor_pos,
-            },
-            replace: text_edit.range,
-        }
-        .into(),
-        None => text_edit.into(),
-    })
-}
-
 pub(crate) fn text_edit_vec(
     line_index: &LineIndex,
     text_edit: TextEdit,

crates/lsp/src/rust_analyzer/to_proto.rs

@@ -141,7 +141,3 @@ pub(crate) fn indent_style_from_vsc(insert_spaces: bool) -> settings::IndentStyl
         settings::IndentStyle::Tab
     }
 }
-
-pub(crate) fn line_width_from_vsc(rulers: &[usize]) -> Option<settings::LineWidth> {
-    rulers.first().and_then(|w| (*w as u16).try_into().ok())
-}

crates/lsp/src/settings_vsc.rs

@@ -34,9 +34,11 @@ pub(crate) struct WorldState {
     /// currently pushed to the LSP), and cache the symbols with Salsa. The
     /// performance is not currently an issue but this could change once we do
     /// more analysis of symbols in the search path.
+    #[allow(dead_code)]
     pub(crate) console_scopes: Vec<Vec<String>>,
 
     /// Currently installed packages
+    #[allow(dead_code)]
     pub(crate) installed_packages: Vec<String>,
 }
 
@@ -66,11 +68,4 @@ impl WorldState {
     pub(crate) fn workspace_uris(&self) -> Vec<Url> {
         self.documents.iter().map(|elt| elt.0.clone()).collect()
     }
-
-    pub(crate) fn workspace_paths(&self) -> Vec<String> {
-        self.workspace_uris()
-            .into_iter()
-            .map(|uri| uri.to_string())
-            .collect()
-    }
 }

crates/lsp/src/state.rs

@@ -16,6 +16,7 @@ use crate::rust_analyzer::{self, line_index::LineIndex, text_edit::TextEdit};
 use biome_text_size::TextRange;
 use tower_lsp::lsp_types;
 
+#[cfg(test)]
 pub(crate) fn doc_edit_vec(
     line_index: &LineIndex,
     text_edit: TextEdit,

crates/lsp/src/to_proto.rs

@@ -124,10 +124,6 @@ impl WorkspaceSettingsResolver {
         }
     }
 
-    pub(crate) fn len(&self) -> usize {
-        self.path_to_settings_resolver.len()
-    }
-
     /// Return the appropriate [`WorkspaceSettings`] for a given document [`Url`].
     pub(crate) fn settings_for_url(&self, url: &Url) -> WorkspaceSettings {
         if let Ok(Some(path)) = Self::url_to_path(url) {