Use a global test client for all unit tests (#130)

* Gather test utilities into a single `test/` folder

And rename a few files to reflect new location

* Only register capabilities if the client supports at least one

Otherwise we end up sending our test client a request here that it isn't expecting at this time, since it didn't say it supported these capabilities

* Return comparable `Id`s, and add `initialized()` support

This is definitely required for lsp-server, otherwise it can't proceed, but is also the right thing to do as a client in general

* Move initialization/shutdown test to integration test

With new support for sending `initialized()` too

* Use a single global test client in all unit tests

* Enforce single tracing subscriber even during tests

* Remove `--test-threads 1` from CI

Author: DavisVaughan

.github/workflows/test-linux.yml

@@ -54,5 +54,4 @@ jobs:
         env:
           AIR_LOG_LEVEL: trace
         # `--nocapture` to see our own `tracing` logs
-        # `--test-threads 1` to ensure `tracing` logs aren't interleaved
-        run: cargo test -- --nocapture --test-threads 1
+        run: cargo test -- --nocapture

.github/workflows/test-mac.yml

@@ -32,5 +32,4 @@ jobs:
         env:
           AIR_LOG_LEVEL: trace
         # `--nocapture` to see our own `tracing` logs
-        # `--test-threads 1` to ensure `tracing` logs aren't interleaved
-        run: cargo test -- --nocapture --test-threads 1
+        run: cargo test -- --nocapture

.github/workflows/test-windows.yml

@@ -32,5 +32,4 @@ jobs:
         env:
           AIR_LOG_LEVEL: trace
         # `--nocapture` to see our own `tracing` logs
-        # `--test-threads 1` to ensure `tracing` logs aren't interleaved
-        run: cargo test -- --nocapture --test-threads 1
+        run: cargo test -- --nocapture

crates/lsp/src/documents.rs

@@ -91,7 +91,7 @@ impl Document {
 
     #[cfg(test)]
     pub fn doodle_and_range(contents: &str) -> (Self, biome_text_size::TextRange) {
-        let (contents, range) = crate::test_utils::extract_marked_range(contents);
+        let (contents, range) = crate::test::extract_marked_range(contents);
         let doc = Self::new(contents, None, PositionEncoding::Utf8);
         (doc, range)
     }

crates/lsp/src/handlers.rs

@@ -73,10 +73,13 @@ pub(crate) async fn handle_initialized(
         registrations.push(watch_air_toml_registration);
     }
 
-    client
-        .register_capability(registrations)
-        .instrument(span.exit())
-        .await?;
+    if !registrations.is_empty() {
+        client
+            .register_capability(registrations)
+            .instrument(span.exit())
+            .await?;
+    }
+
     Ok(())
 }