Skip to content

Commit 0238dac

Browse files
committed
feat(pkg-py): Add .app() method, enable bookmarking by default
1 parent 5e3978d commit 0238dac

File tree

6 files changed

+163
-13
lines changed

6 files changed

+163
-13
lines changed

pkg-py/CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [UNRELEASED]
9+
10+
### New features
11+
12+
* New `QueryChat.app()` method enables quicker/easier chatting with a dataset. (#xx)
13+
* Enabled bookmarking by default in both `.app()` and `.server()` methods. In latter case, you'll need to also specify the `bookmark_store` (either in `shiny.App()` or `shiny.express.app_opts()`) for it to take effect. (#xx)
14+
15+
816
## [UNRELEASED]
917

1018
### Changes

pkg-py/src/querychat/_icons.py

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
from typing import Literal
2+
3+
from shiny import ui
4+
5+
ICON_NAMES = Literal["funnel-fill", "terminal-fill", "table"]
6+
7+
8+
def bs_icon(name: ICON_NAMES) -> ui.HTML:
9+
"""Get Bootstrap icon SVG by name."""
10+
if name not in BS_ICONS:
11+
raise ValueError(f"Unknown Bootstrap icon: {name}")
12+
return ui.HTML(BS_ICONS[name])
13+
14+
15+
BS_ICONS = {
16+
"funnel-fill": '<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="currentColor" class="bi bi-funnel-fill" viewBox="0 0 16 16"><path d="M1.5 1.5A.5.5 0 0 1 2 1h12a.5.5 0 0 1 .5.5v2a.5.5 0 0 1-.128.334L10 8.692V13.5a.5.5 0 0 1-.342.474l-3 1A.5.5 0 0 1 6 14.5V8.692L1.628 3.834A.5.5 0 0 1 1.5 3.5z"/></svg>',
17+
"terminal-fill": '<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" class="bi bi-terminal-fill " style="height:1em;width:1em;fill:currentColor;vertical-align:-0.125em;" aria-hidden="true" role="img" ><path d="M0 3a2 2 0 0 1 2-2h12a2 2 0 0 1 2 2v10a2 2 0 0 1-2 2H2a2 2 0 0 1-2-2V3zm9.5 5.5h-3a.5.5 0 0 0 0 1h3a.5.5 0 0 0 0-1zm-6.354-.354a.5.5 0 1 0 .708.708l2-2a.5.5 0 0 0 0-.708l-2-2a.5.5 0 1 0-.708.708L4.793 6.5 3.146 8.146z"></path></svg>',
18+
"table": '<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" class="bi bi-table " style="height:1em;width:1em;fill:currentColor;vertical-align:-0.125em;" aria-hidden="true" role="img" ><path d="M0 2a2 2 0 0 1 2-2h12a2 2 0 0 1 2 2v12a2 2 0 0 1-2 2H2a2 2 0 0 1-2-2V2zm15 2h-4v3h4V4zm0 4h-4v3h4V8zm0 4h-4v3h3a1 1 0 0 0 1-1v-2zm-5 3v-3H6v3h4zm-5 0v-3H1v2a1 1 0 0 0 1 1h3zm-4-4h4V8H1v3zm0-4h4V4H1v3zm5-3v3h4V4H6zm4 4H6v3h4V8z"></path></svg>',
19+
}

pkg-py/src/querychat/_querychat.py

Lines changed: 101 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,14 @@
1010
import chatlas
1111
import chevron
1212
import sqlalchemy
13-
from shiny import ui
13+
from shiny import App, Inputs, Outputs, Session, reactive, render, req, ui
1414
from shiny.session import get_current_session
15+
from shinychat import output_markdown_stream
1516

17+
from ._icons import bs_icon
18+
from ._querychat_impl import (
19+
normalize_data_source,
20+
)
1621
from ._querychat_module import ModServerResult, mod_server, mod_ui
1722
from .datasource import DataFrameSource, DataSource, SQLAlchemySource
1823

@@ -134,6 +139,99 @@ def __init__(
134139
# Populated when ._server() gets called (in an active session)
135140
self._server_values: ModServerResult | None = None
136141

142+
def app(
143+
self, *, bookmark_store: Literal["url", "server", "disable"] = "url"
144+
) -> App:
145+
"""
146+
Quickly chat with a dataset.
147+
148+
Creates a Shiny app with a chat sidebar and data table view -- providing a
149+
quick-and-easy way to start chatting with your data.
150+
151+
Parameters
152+
----------
153+
bookmark_store
154+
The bookmarking store to use for the Shiny app. Options are:
155+
- `"url"`: Store bookmarks in the URL (default).
156+
- `"server"`: Store bookmarks on the server.
157+
- `"disable"`: Disable bookmarking.
158+
159+
Returns
160+
-------
161+
:
162+
A Shiny App object that can be run with `app.run()` or served with `shiny run`.
163+
164+
"""
165+
enable_bookmarking = bookmark_store != "disable"
166+
table_name = self.data_source.table_name
167+
168+
def app_ui(request):
169+
return ui.page_sidebar(
170+
self.sidebar(),
171+
ui.card(
172+
ui.card_header(
173+
ui.div(
174+
ui.div(
175+
bs_icon("terminal-fill"),
176+
ui.output_text("query_title", inline=True),
177+
class_="d-flex align-items-center gap-2",
178+
),
179+
ui.output_ui("ui_reset", inline=True),
180+
class_="hstack gap-3",
181+
),
182+
),
183+
ui.output_ui("sql_output"),
184+
fill=False,
185+
style="max-height: 33%;",
186+
),
187+
ui.card(
188+
ui.card_header(bs_icon("table"), " Data"),
189+
ui.output_data_frame("dt"),
190+
),
191+
title=ui.span("querychat with ", ui.code(table_name)),
192+
class_="bslib-page-dashboard",
193+
fillable=True,
194+
)
195+
196+
def app_server(input: Inputs, output: Outputs, session: Session):
197+
self._server(enable_bookmarking=enable_bookmarking)
198+
199+
@render.text
200+
def query_title():
201+
return self.title() or "SQL Query"
202+
203+
@render.ui
204+
def ui_reset():
205+
req(self.sql())
206+
return ui.input_action_button(
207+
"reset_query",
208+
"Reset Query",
209+
class_="btn btn-outline-danger btn-sm lh-1 ms-auto",
210+
)
211+
212+
@reactive.effect
213+
@reactive.event(input.reset_query)
214+
def _():
215+
self.sql("")
216+
self.title(None)
217+
218+
@render.data_frame
219+
def dt():
220+
return self.df()
221+
222+
@render.ui
223+
def sql_output():
224+
sql = self.sql() or f"SELECT * FROM {table_name}"
225+
sql_code = f"```sql\n{sql}\n```"
226+
return output_markdown_stream(
227+
"sql_code",
228+
content=sql_code,
229+
auto_scroll=False,
230+
width="100%",
231+
)
232+
233+
return App(app_ui, app_server, bookmark_store=bookmark_store)
234+
137235
def sidebar(
138236
self,
139237
*,
@@ -184,7 +282,7 @@ def ui(self, **kwargs):
184282
"""
185283
return mod_ui(self.id, **kwargs)
186284

187-
def _server(self):
285+
def _server(self, *, enable_bookmarking: bool = True) -> None:
188286
"""
189287
Initialize the server module.
190288
@@ -212,6 +310,7 @@ def _server(self):
212310
system_prompt=self.system_prompt,
213311
greeting=self.greeting,
214312
client=self.client,
313+
enable_bookmarking=enable_bookmarking,
215314
)
216315

217316
return

pkg-py/src/querychat/_querychat_module.py

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import chatlas
1515
import pandas as pd
1616
from shiny import Inputs, Outputs, Session
17+
from shiny.bookmark import BookmarkState, RestoreState
1718

1819
from .datasource import DataSource
1920

@@ -60,10 +61,12 @@ def mod_server(
6061
system_prompt: str,
6162
greeting: str | None,
6263
client: chatlas.Chat,
64+
enable_bookmarking: bool = False,
6365
):
6466
# Reactive values to store state
6567
sql = ReactiveString("")
6668
title = ReactiveStringOrNone(None)
69+
has_greeted = reactive.value[bool](False) # noqa: FBT003
6770

6871
# Set up the chat object for this session
6972
chat = copy.deepcopy(client)
@@ -99,6 +102,9 @@ async def _(user_input: str):
99102

100103
@reactive.effect
101104
async def greet_on_startup():
105+
if has_greeted():
106+
return
107+
102108
if greeting:
103109
await chat_ui.append_message(greeting)
104110
elif greeting is None:
@@ -108,6 +114,8 @@ async def greet_on_startup():
108114
)
109115
await chat_ui.append_message_stream(stream)
110116

117+
has_greeted.set(True)
118+
111119
# Handle update button clicks
112120
@reactive.effect
113121
@reactive.event(input.chat_update)
@@ -125,4 +133,26 @@ def _():
125133
if new_title is not None:
126134
title.set(new_title)
127135

136+
if enable_bookmarking:
137+
chat_ui.enable_bookmarking(client)
138+
139+
def _on_bookmark(x: BookmarkState) -> None:
140+
vals = x.values # noqa: PD011
141+
vals["querychat_sql"] = sql.get()
142+
vals["querychat_title"] = title.get()
143+
vals["querychat_has_greeted"] = has_greeted.get()
144+
145+
session.bookmark.on_bookmark(_on_bookmark)
146+
147+
def _on_restore(x: RestoreState) -> None:
148+
vals = x.values # noqa: PD011
149+
if "querychat_sql" in vals:
150+
sql.set(vals["querychat_sql"])
151+
if "querychat_title" in vals:
152+
title.set(vals["querychat_title"])
153+
if "querychat_has_greeted" in vals:
154+
has_greeted.set(vals["querychat_has_greeted"])
155+
156+
session.bookmark.on_restore(_on_restore)
157+
128158
return ModServerResult(df=filtered_df, sql=sql, title=title, client=chat)

pkg-py/src/querychat/tools.py

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55

66
import chevron
77
from chatlas import ContentToolResult, Tool
8-
from htmltools import HTML
98
from shinychat.types import ToolResultDisplay
109

10+
from ._icons import bs_icon
1111
from ._utils import df_to_html
1212

1313
if TYPE_CHECKING:
@@ -66,9 +66,7 @@ def update_dashboard(query: str, title: str) -> ContentToolResult:
6666
title=title,
6767
show_request=False,
6868
open=True,
69-
icon=HTML(
70-
'<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="currentColor" class="bi bi-funnel-fill" viewBox="0 0 16 16"><path d="M1.5 1.5A.5.5 0 0 1 2 1h12a.5.5 0 0 1 .5.5v2a.5.5 0 0 1-.128.334L10 8.692V13.5a.5.5 0 0 1-.342.474l-3 1A.5.5 0 0 1 6 14.5V8.692L1.628 3.834A.5.5 0 0 1 1.5 3.5z"/></svg>',
71-
),
69+
icon=bs_icon("funnel-fill"),
7270
),
7371
},
7472
)
@@ -142,9 +140,7 @@ def reset_dashboard() -> ContentToolResult:
142140
title=None,
143141
show_request=False,
144142
open=False,
145-
icon=HTML(
146-
'<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" class="bi bi-arrow-counterclockwise" style="height:1em;width:1em;fill:currentColor;vertical-align:-0.125em;" aria-hidden="true" role="img"><path fill-rule="evenodd" d="M8 3a5 5 0 1 1-4.546 2.914.5.5 0 0 0-.908-.417A6 6 0 1 0 8 2v1z"></path><path d="M8 4.466V.534a.25.25 0 0 0-.41-.192L5.23 2.308a.25.25 0 0 0 0 .384l2.36 1.966A.25.25 0 0 0 8 4.466z"></path></svg>',
147-
),
143+
icon=bs_icon("terminal-fill"),
148144
),
149145
},
150146
)
@@ -213,9 +209,7 @@ def query(query: str, _intent: str = "") -> ContentToolResult:
213209
markdown=markdown,
214210
show_request=False,
215211
open=True,
216-
icon=HTML(
217-
'<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="currentColor" class="bi bi-table" viewBox="0 0 16 16"><path d="M0 2a2 2 0 0 1 2-2h12a2 2 0 0 1 2 2v12a2 2 0 0 1-2 2H2a2 2 0 0 1-2-2zm15 2h-4v3h4zm0 4h-4v3h4zm0 4h-4v3h3a1 1 0 0 0 1-1zm-5 3v-3H6v3zm-5 0v-3H1v2a1 1 0 0 0 1 1zm-4-4h4V8H1zm0-4h4V4H1zm5-3v3h4V4zm4 4H6v3h4z"/></svg>',
218-
),
212+
icon=bs_icon("table"),
219213
),
220214
},
221215
)

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ maintainers = [
2121
dependencies = [
2222
"duckdb",
2323
"pandas",
24-
"shiny",
24+
"shiny @ git+https://github.com/posit-dev/py-shiny.git@fix/bookmark-missing-input-error",
2525
"shinywidgets",
2626
"htmltools",
2727
"chatlas>=0.13.2",

0 commit comments

Comments
 (0)