From 45e3395f77d1399e41246ec24df6092c7c0b6cd0 Mon Sep 17 00:00:00 2001 From: Dan Balasescu Date: Mon, 15 Apr 2024 19:58:14 +0900 Subject: [PATCH] Fix inspections --- osu.Server.QueueProcessor/ConnectionMultiplexerExtensions.cs | 4 ++-- osu.Server.QueueProcessor/QueueProcessor.cs | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/osu.Server.QueueProcessor/ConnectionMultiplexerExtensions.cs b/osu.Server.QueueProcessor/ConnectionMultiplexerExtensions.cs index 6a94597..a859fda 100644 --- a/osu.Server.QueueProcessor/ConnectionMultiplexerExtensions.cs +++ b/osu.Server.QueueProcessor/ConnectionMultiplexerExtensions.cs @@ -34,7 +34,7 @@ public static void ClearCurrentSchema(this ConnectionMultiplexer connection) /// /// Get all active schemas (including past or future). /// - public static string[] GetActiveSchemas(this ConnectionMultiplexer connection) + public static string?[] GetActiveSchemas(this ConnectionMultiplexer connection) { return connection.GetDatabase().SetMembers(allActiveSchemasKey).ToStringArray(); } @@ -44,7 +44,7 @@ public static string[] GetActiveSchemas(this ConnectionMultiplexer connection) /// public static string GetCurrentSchema(this ConnectionMultiplexer connection) { - return connection.GetDatabase().StringGet(mainSchemaKey).ToString() ?? string.Empty; + return connection.GetDatabase().StringGet(mainSchemaKey).ToString(); } /// diff --git a/osu.Server.QueueProcessor/QueueProcessor.cs b/osu.Server.QueueProcessor/QueueProcessor.cs index e44d058..8fd2df0 100644 --- a/osu.Server.QueueProcessor/QueueProcessor.cs +++ b/osu.Server.QueueProcessor/QueueProcessor.cs @@ -107,6 +107,7 @@ public void Run(CancellationToken cancellation = default) var redisItems = database.ListRightPop(QueueName, config.BatchSize); + // ReSharper disable once ConditionIsAlwaysTrueOrFalseAccordingToNullableAPIContract (https://github.com/StackExchange/StackExchange.Redis/issues/2697) // queue doesn't exist. if (redisItems == null) {