Skip to content

Commit ee6dcbd

Browse files
committed
Fix android build again
Another month, another freak android build failure. From what I can tell, this time the build is broken because the second- -to-last workaround applied to fix it, namely explicitly specifying the version of workloads to install, stopped working, presumably because github pushed a new .NET SDK version to runners, and microsoft didn't actually put up a set of workload packages whose version matches the .NET SDK version 1:1. Thankfully, the fix to the *last* android build breakage (which caused the workload installation to completely and irrecoverably fail), appears to be rolling out this week, and *also* fix that same second-last issue, so both workarounds of specifying the workload version and pinning the image to `windows-2019` appear to no longer be required. Note that the newest image version, 20250209.1.0, is still not fully rolled out yet, thus rather than just fix all builds, this will fix like 20% of builds until the newest image is fully rolled out. But I guess a 20% passing build is better than a 0% passing build, in a sense...?
1 parent 0612c0a commit ee6dcbd

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

.github/workflows/ci.yml

+2-5
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ jobs:
9696

9797
build-only-android:
9898
name: Build only (Android)
99-
runs-on: windows-2019
99+
runs-on: windows-latest
100100
timeout-minutes: 60
101101
steps:
102102
- name: Checkout
@@ -114,10 +114,7 @@ jobs:
114114
dotnet-version: "8.0.x"
115115

116116
- name: Install .NET workloads
117-
# since windows image 20241113.3.0, not specifying a version here
118-
# installs the .NET 7 version of android workload for very unknown reasons.
119-
# revisit once we upgrade to .NET 9, it's probably fixed there.
120-
run: dotnet workload install android --version (dotnet --version)
117+
run: dotnet workload install android
121118

122119
- name: Compile
123120
run: dotnet build -c Debug osu.Android.slnf

0 commit comments

Comments
 (0)