Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back comboburst #4629

Open
KirbyJoe opened this issue Apr 16, 2019 · 7 comments · May be fixed by #17616
Open

Add back comboburst #4629

KirbyJoe opened this issue Apr 16, 2019 · 7 comments · May be fixed by #17616
Labels
area:gameplay priority:2 Moderately important. Relied on by some users or impeding the usability of the game

Comments

@KirbyJoe
Copy link

Describe the missing feature:
Comboburst is described on the glossary like this:

A comboburst is a celebration of achieving a combo milestone.

The visual effect is missing on osu!lazer.

@peppy peppy changed the title Comboburst Add back comboburst Apr 17, 2019
@peppy peppy added this to the Candidate Issues milestone Apr 17, 2019
@peppy peppy modified the milestone: Candidate Issues Feb 17, 2020
@greenmg2003
Copy link

greenmg2003 commented Jan 23, 2022

If it can be added back, I may suggest the mechanic of lazer combo-burst, based on what I have said in #16578:
So in stable, 30×, 60×, 100×, 150×, 200×,..., each one has the combo-burst images.
And what I think for new system in lazer is in first 1000 combos, exact 50× combos and 1 image of combo-burst will appear. If combo count get 1000+, 100 combos/1 combo-burst image, same to 2000+ then 200 combos/1 combo-burst image, and so on.

@mk56-spn
Copy link
Contributor

Idk. Is this really a necessary thing ? Maybe for legacy's sake but I doubt it'll be prioritized

@greenmg2003
Copy link

greenmg2003 commented Jan 23, 2022

Idk. Is this really a necessary thing ? Maybe for legacy's sake but I doubt it'll be prioritized

This can be necessary, to cheer people for getting a milestone after making a chain combo. If players just, go to osu!, click the circles only, without encouragement from the skin they choose, then players can easily get upset when they are trying to pass a hard map.
Not the most priority stuff, but at least, it's needed for osu! traditions too. And like I mentioned in #16578 , there should be a button to turn off the combo-burst if people don't want to see it.

@mk56-spn
Copy link
Contributor

Idk. Is this really a necessary thing ? Maybe for legacy's sake but I doubt it'll be prioritized

This can be necessary, to cheer people for getting a milestone after making a chain combo. If you just, go to osu!, click the circles only, without encouragement from the skin they choose, then players can easily get upset when they are trying to pass a hard map.
Not the most priority stuff, but at least, it's needed for osu! traditions too. And like I mentioned in #16578 , there should be a button to turn off the combo-burst if people don't want to see it.

Understandable I guess. Keep in mind combo will likely become a lot less meaningful with the upcoming combo scaling removal rework from PP. Which effectively makes holding combo devoid of any value. But yeah thisll probs get added when skinning gets done

@greenmg2003
Copy link

Understandable I guess. Keep in mind combo will likely become a lot less meaningful with the upcoming combo scaling removal rework from PP. Which effectively makes holding combo devoid of any value. But yeah thisll probs get added when skinning gets done

Thanks for informing! It's clearly enough, now I'll wait for the news from osu! lazer skinning too! Hope this issue will be closed after the combo-burst has been added in the game!

@Cookiesmuch
Copy link

Sorry if this counts as ghost-posting, however I would like to say that if someone made the code for the Stable! Combo burst publically available, so that someone (even an unaffiliated contributor) may quickly add it to Lazer. As far as I'm aware, this is how the Smoke was added to Lazer as well.

@peppy peppy linked a pull request Jan 9, 2023 that will close this issue
@SysError99
Copy link

SysError99 commented Apr 2, 2024

In my humble opinion, unless the combo burst is really something that's only specific to certain rulesets, this deserves more consideration on a proper API for other rulesets too.

@peppy peppy added the priority:2 Moderately important. Relied on by some users or impeding the usability of the game label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:gameplay priority:2 Moderately important. Relied on by some users or impeding the usability of the game
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants