Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urandom: compile error on Windows with Nim 2.0 #8

Closed
ee7 opened this issue Aug 6, 2023 · 1 comment
Closed

urandom: compile error on Windows with Nim 2.0 #8

ee7 opened this issue Aug 6, 2023 · 1 comment

Comments

@ee7
Copy link
Contributor

ee7 commented Aug 6, 2023 •
edited
Loading

On Windows, Nim 2.0 produces a compile error for this package:

$ nim --version
Nim Compiler Version 2.0.0 [Linux: amd64]
Compiled at 2023-08-01
Copyright (c) 2006-2023 by Andreas Rumpf

git hash: a488067a4130f029000be4550a0fb1b39e0e9e7c
active boot switches: -d:release
$ nim c --os:windows uuids/urandom.nim
/foo/pragmagic-uuids/uuids/urandom.nim(15, 8) Error: undeclared identifier: 'useWinUnicode'

This is because Nim 2.0 removed useWinUnicode.

I'll make a PR.

Maybe related: #7
ee7 added a commit to ee7/pragmagic-uuids that referenced this issue Aug 6, 2023
@ee7
urandom: fix for Nim 2.0 by using only CryptAcquireContextW
d1c5da9 
Before this commit, compiling urandom.nim on Windows with Nim 2.0 would
produce an error:

     $ nim c --os:windows uuids/urandom.nim
     /foo/pragmagic-uuids/uuids/urandom.nim(15, 8) Error: undeclared identifier: 'useWinUnicode'

This was because Nim 2.0 [1] removed the useWinUnicode identifier [2].

Fix by always using CryptAcquireContextW on Windows.

Fixes: pragmagic#8

[1] https://nim-lang.org/blog/2023/08/01/nim-v20-released.html
[2] nim-lang/Nim@612abda
ee7 added a commit to ee7/pragmagic-uuids that referenced this issue Aug 6, 2023
@ee7
urandom: fix for Nim 2.0 by using only CryptAcquireContextW
6be643f 
Before this commit, compiling urandom.nim on Windows with Nim 2.0 would
produce an error:

    $ nim c --os:windows uuids/urandom.nim
    /foo/pragmagic-uuids/uuids/urandom.nim(15, 8) Error: undeclared identifier: 'useWinUnicode'

This was because Nim 2.0 [1] removed the useWinUnicode identifier [2].

Fix by always using CryptAcquireContextW on Windows.

Fixes: pragmagic#8

[1] https://nim-lang.org/blog/2023/08/01/nim-v20-released.html
[2] nim-lang/Nim@612abda
@ee7 ee7 mentioned this issue Aug 6, 2023
Closed
@endragor
Copy link
Member

Fixed by #10 in v0.1.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

urandom: fix for Nim 2.0 by using only CryptAcquireContextW ee7/pragmagic-uuids
2 participants
@endragor @ee7